[sim] Consistent support for C calls with up to 9 args

[sim] Consistent support for C calls with up to 9 args

Consistently support calls to host-C-linkage functions with up to 9 arguments
from the simulator, and check that these limits aren't exceeded accidentally.

BUG=v8:6281
Review-Url: https://codereview.chromium.org/2825393003
Cr-Commit-Position: refs/heads/master@{#44790}
Committed: https://chromium.googlesource.com/v8/v8/+/3337ccccd97bf226d81124206c16eafc216f0ae8

[jgruber, 2017-04-20 13:34:07]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 13:34:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 13:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 13:35:46]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/24622)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/39484)

[jgruber, 2017-04-21 12:42:15]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 12:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-21 12:45:23]

Description was changed from

==========
[sim] Consistent support for C calls with up to 9 args

Consistently support calls to host-C-linkage functions from the simulator, and
check that these limits aren't exceeded accidentally.

BUG=v8:6281
==========

to

==========
[sim] Consistent support for C calls with up to 9 args

Consistently support calls to host-C-linkage functions with up to 9 arguments
from the simulator, and check that these limits aren't exceeded accidentally.

BUG=v8:6281
==========

[commit-bot: I haz the power, 2017-04-21 12:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 12:46:10]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/24763)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[jgruber, 2017-04-24 07:08:51]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 07:08:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 07:35:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 07:35:37]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-04-24 07:37:42]

jgruber@chromium.org changed reviewers:
+ georgia.kouveli@arm.com, mstarzinger@chromium.org

[jgruber, 2017-04-24 07:37:42]

+georgia fyi for arm/arm64.

This adds consistent support for up to 9 args for calling host-C-linkage
functions from the simulator. DCHECKs are added in the CFunctionCall macro
assembler fns and when creating the call descriptor.

Ports for ppc and s390 not included. PTAL.

[Michael Starzinger, 2017-04-24 08:25:56]

LGTM.

https://codereview.chromium.org/2825393003/diff/40001/src/macro-assembler.h
File src/macro-assembler.h (right):

https://codereview.chromium.org/2825393003/diff/40001/src/macro-assembler.h#n...
src/macro-assembler.h:69: enum { kMaxCParameters = 9 };
bit: Why enum instead of "const int"?

[jgruber, 2017-04-24 11:28:50]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 11:28:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-24 11:39:05]

https://codereview.chromium.org/2825393003/diff/40001/src/macro-assembler.h
File src/macro-assembler.h (right):

https://codereview.chromium.org/2825393003/diff/40001/src/macro-assembler.h#n...
src/macro-assembler.h:69: enum { kMaxCParameters = 9 };
On 2017/04/24 08:25:56, Michael Starzinger wrote:
> bit: Why enum instead of "const int"?

No real reason. Changed to static constexpr int.

[commit-bot: I haz the power, 2017-04-24 11:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 11:55:54]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-04-24 11:57:06]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-24 11:57:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2825393003/#ps60001
(title: "enum -> const variable")

[commit-bot: I haz the power, 2017-04-24 11:57:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 11:58:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493035026037320,
"parent_rev": "6d9830e41a01c983a4de0a6b08dfcaaf87d539b4", "commit_rev":
"3337ccccd97bf226d81124206c16eafc216f0ae8"}

[commit-bot: I haz the power, 2017-04-24 11:59:02]

Description was changed from

==========
[sim] Consistent support for C calls with up to 9 args

Consistently support calls to host-C-linkage functions with up to 9 arguments
from the simulator, and check that these limits aren't exceeded accidentally.

BUG=v8:6281
==========

to

==========
[sim] Consistent support for C calls with up to 9 args

Consistently support calls to host-C-linkage functions with up to 9 arguments
from the simulator, and check that these limits aren't exceeded accidentally.

BUG=v8:6281

Review-Url: https://codereview.chromium.org/2825393003
Cr-Commit-Position: refs/heads/master@{#44790}
Committed:
https://chromium.googlesource.com/v8/v8/+/3337ccccd97bf226d81124206c16eafc216...
==========

[commit-bot: I haz the power, 2017-04-24 11:59:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/3337ccccd97bf226d81124206c16eafc216...