Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2825353002: Replace ASSERT_NOT_REACHED with NOTREACHED in modules/accessibility (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
tkent, haraken
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED with NOTREACHED in modules/accessibility BUG=707651 Review-Url: https://codereview.chromium.org/2825353002 Cr-Commit-Position: refs/heads/master@{#465628} Committed: https://chromium.googlesource.com/chromium/src/+/281d38cd426b801aa0a1323f579d3c5a0f340d85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 8 months ago (2017-04-19 14:26:49 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-19 14:30:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825353002/1
3 years, 8 months ago (2017-04-19 16:15:47 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 16:22:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/281d38cd426b801aa0a1323f579d...

Powered by Google App Engine
This is Rietveld 408576698