Fix key repeat on linux.

Fix key repeat on linux.

Events posted from ibus would not get detected as repeating. This caused
issues for web content that relied upon the KeyboardEvent.repeat
javascript attribute. Store the detection of repeated events from ibus
in a separate static variable than the evdev channel.

BUG=711773
Review-Url: https://codereview.chromium.org/2825343002
Cr-Commit-Position: refs/heads/master@{#466332}
Committed: https://chromium.googlesource.com/chromium/src/+/0386ada9ad68b6a562fda8bddd979cf902b87486

[dtapuska, 2017-04-19 13:31:59]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 13:32:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-04-19 13:39:57]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2017-04-19 13:40:00]

dtapuska@chromium.org changed reviewers:
+ sadrul@chromium.org

[dtapuska, 2017-04-19 13:40:01]

PTAL this fixes some code oshima@ originally wrote in
https://chromium.googlesource.com/chromium/src.git/+/2c988d7a5f25a0d6b4b84baf...
and threw out ibus messages.

[commit-bot: I haz the power, 2017-04-19 13:40:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 14:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 14:39:59]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2017-04-20 21:06:17]

On 2017/04/19 13:40:01, dtapuska wrote:
> PTAL this fixes some code oshima@ originally wrote in
>
https://chromium.googlesource.com/chromium/src.git/+/2c988d7a5f25a0d6b4b84baf...
> and threw out ibus messages.

sadrul@ ping

[sadrul, 2017-04-21 03:08:22]

lgtm

https://codereview.chromium.org/2825343002/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2825343002/diff/1/ui/events/event.cc#newcode1088
ui/events/event.cc:1088: KeyEvent* KeyEvent::last_ibus_key_event_ = NULL;
nullptr

[dtapuska, 2017-04-21 13:22:40]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2017-04-21 13:22:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2825343002/#ps20001
(title: "Fix nit")

[commit-bot: I haz the power, 2017-04-21 13:22:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-04-21 13:22:55]

https://codereview.chromium.org/2825343002/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2825343002/diff/1/ui/events/event.cc#newcode1088
ui/events/event.cc:1088: KeyEvent* KeyEvent::last_ibus_key_event_ = NULL;
On 2017/04/21 03:08:22, sadrul wrote:
> nullptr

Done.

[commit-bot: I haz the power, 2017-04-21 14:53:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492780960427520,
"parent_rev": "9cb3b1d088bdd435de0292a58966c4c514acd0a1", "commit_rev":
"0386ada9ad68b6a562fda8bddd979cf902b87486"}

[commit-bot: I haz the power, 2017-04-21 14:53:33]

Description was changed from

==========
Fix key repeat on linux.

Events posted from ibus would not get detected as repeating. This caused
issues for web content that relied upon the KeyboardEvent.repeat
javascript attribute. Store the detection of repeated events from ibus
in a separate static variable than the evdev channel.

BUG=711773
==========

to

==========
Fix key repeat on linux.

Events posted from ibus would not get detected as repeating. This caused
issues for web content that relied upon the KeyboardEvent.repeat
javascript attribute. Store the detection of repeated events from ibus
in a separate static variable than the evdev channel.

BUG=711773

Review-Url: https://codereview.chromium.org/2825343002
Cr-Commit-Position: refs/heads/master@{#466332}
Committed:
https://chromium.googlesource.com/chromium/src/+/0386ada9ad68b6a562fda8bddd97...
==========

[commit-bot: I haz the power, 2017-04-21 14:53:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0386ada9ad68b6a562fda8bddd97...