Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2825333004: Improve error message for PaymentRequest.abort(). (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews, gogerald+paymentswatch_chromium.org, haraken, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve error message for PaymentRequest.abort(). Before this patch, calling PaymentRequest.abort() would reject the PaymentRequest.show() promise with a message "DOMException: The user aborted a request." This is misleading, because it is the merchant that's initiating the abort. The fix is to change the message to "The website has aborted the payment." BUG=713206 Review-Url: https://codereview.chromium.org/2825333004 Cr-Commit-Position: refs/heads/master@{#465697} Committed: https://chromium.googlesource.com/chromium/src/+/58ee54b41b1703b1cb78d5d281611ed3629b8e78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
please use gerrit instead
Marijn, ptal.
3 years, 8 months ago (2017-04-19 15:52:48 UTC) #4
Marijn Kruisselbrink
lgtm
3 years, 8 months ago (2017-04-19 19:05:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825333004/1
3 years, 8 months ago (2017-04-19 19:08:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:13:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58ee54b41b1703b1cb78d5d28161...

Powered by Google App Engine
This is Rietveld 408576698