Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 2825333003: Remove kRenderTarget flag when wrapping a texture as an SkImage in skcanvas_video_renderer (Closed)

Created:
3 years, 8 months ago by egdaniel1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kRenderTarget flag when wrapping a texture as an SkImage in skcanvas_video_renderer BUG= Review-Url: https://codereview.chromium.org/2825333003 Cr-Commit-Position: refs/heads/master@{#465703} Committed: https://chromium.googlesource.com/chromium/src/+/1e95b5f01fd47bf48a9136c894e290ac2d8561b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/renderers/skcanvas_video_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
egdaniel1
I'm and working on a change in Skia which will no longer take a Flags ...
3 years, 8 months ago (2017-04-19 15:36:17 UTC) #2
DaleCurtis
rs lgtm
3 years, 8 months ago (2017-04-19 17:24:51 UTC) #3
robertphillips
lgtm
3 years, 8 months ago (2017-04-19 17:29:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825333003/1
3 years, 8 months ago (2017-04-19 17:33:59 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:25:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1e95b5f01fd47bf48a9136c894e2...

Powered by Google App Engine
This is Rietveld 408576698