Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2825243002: DialogClientView: Handle nested close requests gracefully.

Created:
3 years, 8 months ago by tapted
Modified:
3 years, 3 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DialogClientView: Handle nested close requests gracefully. This fixes a regression from r459382 where clicking a "Learn More" link on the NTP override bubble can spew out tabs. The problem is that opening a tab may defocus the bubble, triggering a Close(). The extension bubble client must still call close BUG=712545

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -16 lines) Patch
M chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc View 1 2 chunks +16 lines, -4 lines 0 comments Download
M ui/views/window/dialog_client_view.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 3 chunks +34 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (11 generated)
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-19 02:56:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825243002/1
3 years, 8 months ago (2017-04-19 02:56:35 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 03:29:56 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/408113)
3 years, 8 months ago (2017-04-19 03:29:57 UTC) #4
tapted
Description was changed from ========== DialogClientView: handle nested close requests. BUG=712545 ========== to ========== DialogClientView: ...
3 years, 8 months ago (2017-04-19 03:34:40 UTC) #5
tapted
Description was changed from ========== DialogClientView: Gracefully handle nested close requests. BUG=712545 ========== to ========== ...
3 years, 8 months ago (2017-04-19 03:34:57 UTC) #6
tapted
Description was changed from ========== DialogClientView: Handle nested close requests gracefully. BUG=712545 ========== to ========== ...
3 years, 8 months ago (2017-04-19 03:51:26 UTC) #7
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-19 03:54:14 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825243002/20001
3 years, 8 months ago (2017-04-19 03:54:24 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 04:44:57 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 04:44:58 UTC) #11
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698