Plumb CanvasColorParams to canvas image classes

third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
index 74e0cefdb8c8c8bfb85ccbcd086c6a89733e8317..2d4a7656047d0c8b7cd3c8c7448afd25c76bb6dc 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
@@ -896,9 +896,15 @@ ImageBitmap::ImageBitmap(ImageData* data,
     return;
   }
 
-  std::unique_ptr<ImageBuffer> buffer =
-      ImageBuffer::Create(parsed_options.crop_rect.Size(), kNonOpaque,
-                          kDoNotInitializeImagePixels, data->GetSkColorSpace());
+  // TODO(ccameron): Retrieve full CanvasColorParams from ImageData.

[ccameron, 2017/04/18 21:23:50]

I suspect we should make some changes to ImageData as well, but those changes
were more subtle, so I left them out of this (mostly copy-paste) patch.

+  ImageDataColorSettings color_settings;
+  data->getColorSettings(color_settings);
+  CanvasColorSpace canvas_color_space =
+      ImageData::GetCanvasColorSpace(color_settings.colorSpace());
+  CanvasPixelFormat canvas_pixel_format = kRGBA8CanvasPixelFormat;

[zakerinasab, 2017/04/18 21:46:58]

I think we need to set the canvas pixel format for non-srgb color spaces:

if (color_settings.storageFormat() != kUint8ClampedArrayStorageFormatName)
  canvas_pixel_format = kF16CanvasPixelFormat;

[ccameron, 2017/04/18 22:10:45]

Good point -- done.

+  std::unique_ptr<ImageBuffer> buffer = ImageBuffer::Create(
+      parsed_options.crop_rect.Size(), kNonOpaque, kDoNotInitializeImagePixels,
+      CanvasColorParams(canvas_color_space, canvas_pixel_format));
   if (!buffer)
     return;