Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2825173002: Launch "Update Chrome" menu item (Closed)

Created:
3 years, 8 months ago by Theresa
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Launch "Update Chrome" menu item This removes most of the experiment flags and launches the "Update Chrome" menu item. Command line flags were left testing and an experiment flag was left for setting a custom summary in case there is a need in the future. BUG=712827 Review-Url: https://codereview.chromium.org/2825173002 Cr-Commit-Position: refs/heads/master@{#465743} Committed: https://chromium.googlesource.com/chromium/src/+/ce0b29ba87c70d56918a8e551ee13c89b871d2a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -103 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java View 5 chunks +1 line, -25 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +4 lines, -17 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Theresa
ptal
3 years, 8 months ago (2017-04-18 21:19:37 UTC) #3
gone
lgtm
3 years, 8 months ago (2017-04-19 20:40:58 UTC) #7
Theresa
asvitkine@ - ptal at fieldtrial_testing_config.json
3 years, 8 months ago (2017-04-19 20:45:37 UTC) #9
Theresa
asvitkine@ - ptal at fieldtrial_testing_config.json
3 years, 8 months ago (2017-04-19 20:45:39 UTC) #10
Alexei Svitkine (slow)
lgtm
3 years, 8 months ago (2017-04-19 20:49:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825173002/1
3 years, 8 months ago (2017-04-19 20:53:09 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 21:01:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce0b29ba87c70d56918a8e551ee1...

Powered by Google App Engine
This is Rietveld 408576698