gpu: Assert that FencedAllocator is empty in destructor

gpu: Assert that FencedAllocator is empty in destructor

With the commit "gpu: Reuse transfer buffers more aggresively" mapped
memory is free:ed on lost context. This means that we can reinstate the
DCHECKs in the FencedAllocator destructor that checks that all blocks
have been free:ed by their owner.

Tests that didn't explicitly free mapped memory now do so, and one test
that tested that leaking was OK has been removed.

BUG=328808
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270991

[jadahl, 2014-05-12 09:14:55]

This was discussed a while back, in the code review of the previous CL of the
linked bug.

[piman, 2014-05-12 19:29:44]

LGTM, thank.

[jadahl, 2014-05-13 07:26:24]

The CQ bit was checked by jadahl@opera.com

[commit-bot: I haz the power, 2014-05-13 07:26:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jadahl@opera.com/282513003/1

[commit-bot: I haz the power, 2014-05-13 10:45:49]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-13 11:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-13 11:11:47]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[jadahl, 2014-05-15 12:18:27]

Uploaded an updated version where tests also pass on 64 bit (as the test did an
early out on <= 32bit systems).

[piman, 2014-05-15 17:07:15]

lgtm

[jadahl, 2014-05-16 07:23:13]

The CQ bit was checked by jadahl@opera.com

[commit-bot: I haz the power, 2014-05-16 07:23:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jadahl@opera.com/282513003/20001

[commit-bot: I haz the power, 2014-05-16 09:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 09:18:23]

Failed to apply patch for @master/gpu/command_buffer/client/fenced_allocator.cc:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/gpu/command_buffer/client/fenced_allocator.cc
Index: gpu/command_buffer/client/fenced_allocator.cc
diff --git @master/gpu/command_buffer/client/fenced_allocator.cc
@master/gpu/command_buffer/client/fenced_allocator.cc
index
4e405e94e7ad5626094fe9fb91ec365f00189835..80038571be9fccf4e5274101e0959c33aa2586c9
100644
--- a/@master/gpu/command_buffer/client/fenced_allocator.cc
+++ b/@master/gpu/command_buffer/client/fenced_allocator.cc
@@ -50,9 +50,9 @@ FencedAllocator::~FencedAllocator() {
       i = WaitForTokenAndFreeBlock(i);
     }
   }
-  // These checks are not valid if the service has crashed or lost the context.
-  // DCHECK_EQ(blocks_.size(), 1u);
-  // DCHECK_EQ(blocks_[0].state, FREE);
+
+  DCHECK_EQ(blocks_.size(), 1u);
+  DCHECK_EQ(blocks_[0].state, FREE);
 }
 
 // Looks for a non-allocated block that is big enough. Search in the FREE

[jadahl, 2014-05-16 09:22:11]

The CQ bit was checked by jadahl@opera.com

[commit-bot: I haz the power, 2014-05-16 09:22:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jadahl@opera.com/282513003/20001

[commit-bot: I haz the power, 2014-05-16 09:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 09:23:55]

Failed to apply patch for @master/gpu/command_buffer/client/fenced_allocator.cc:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/gpu/command_buffer/client/fenced_allocator.cc
Index: gpu/command_buffer/client/fenced_allocator.cc
diff --git @master/gpu/command_buffer/client/fenced_allocator.cc
@master/gpu/command_buffer/client/fenced_allocator.cc
index
4e405e94e7ad5626094fe9fb91ec365f00189835..80038571be9fccf4e5274101e0959c33aa2586c9
100644
--- a/@master/gpu/command_buffer/client/fenced_allocator.cc
+++ b/@master/gpu/command_buffer/client/fenced_allocator.cc
@@ -50,9 +50,9 @@ FencedAllocator::~FencedAllocator() {
       i = WaitForTokenAndFreeBlock(i);
     }
   }
-  // These checks are not valid if the service has crashed or lost the context.
-  // DCHECK_EQ(blocks_.size(), 1u);
-  // DCHECK_EQ(blocks_[0].state, FREE);
+
+  DCHECK_EQ(blocks_.size(), 1u);
+  DCHECK_EQ(blocks_[0].state, FREE);
 }
 
 // Looks for a non-allocated block that is big enough. Search in the FREE

[Paweł Hajdan Jr., 2014-05-16 11:00:03]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:00:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jadahl@opera.com/282513003/20001

[commit-bot: I haz the power, 2014-05-16 11:02:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:02:21]

Failed to apply patch for @master/gpu/command_buffer/client/fenced_allocator.cc:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/gpu/command_buffer/client/fenced_allocator.cc
Index: gpu/command_buffer/client/fenced_allocator.cc
diff --git @master/gpu/command_buffer/client/fenced_allocator.cc
@master/gpu/command_buffer/client/fenced_allocator.cc
index
4e405e94e7ad5626094fe9fb91ec365f00189835..80038571be9fccf4e5274101e0959c33aa2586c9
100644
--- a/@master/gpu/command_buffer/client/fenced_allocator.cc
+++ b/@master/gpu/command_buffer/client/fenced_allocator.cc
@@ -50,9 +50,9 @@ FencedAllocator::~FencedAllocator() {
       i = WaitForTokenAndFreeBlock(i);
     }
   }
-  // These checks are not valid if the service has crashed or lost the context.
-  // DCHECK_EQ(blocks_.size(), 1u);
-  // DCHECK_EQ(blocks_[0].state, FREE);
+
+  DCHECK_EQ(blocks_.size(), 1u);
+  DCHECK_EQ(blocks_[0].state, FREE);
 }
 
 // Looks for a non-allocated block that is big enough. Search in the FREE

[Paweł Hajdan Jr., 2014-05-16 11:19:53]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:20:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jadahl@opera.com/282513003/20001

[commit-bot: I haz the power, 2014-05-16 11:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:21:12]

Failed to apply patch for @master/gpu/command_buffer/client/fenced_allocator.cc:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/gpu/command_buffer/client/fenced_allocator.cc
Index: gpu/command_buffer/client/fenced_allocator.cc
diff --git @master/gpu/command_buffer/client/fenced_allocator.cc
@master/gpu/command_buffer/client/fenced_allocator.cc
index
4e405e94e7ad5626094fe9fb91ec365f00189835..80038571be9fccf4e5274101e0959c33aa2586c9
100644
--- a/@master/gpu/command_buffer/client/fenced_allocator.cc
+++ b/@master/gpu/command_buffer/client/fenced_allocator.cc
@@ -50,9 +50,9 @@ FencedAllocator::~FencedAllocator() {
       i = WaitForTokenAndFreeBlock(i);
     }
   }
-  // These checks are not valid if the service has crashed or lost the context.
-  // DCHECK_EQ(blocks_.size(), 1u);
-  // DCHECK_EQ(blocks_[0].state, FREE);
+
+  DCHECK_EQ(blocks_.size(), 1u);
+  DCHECK_EQ(blocks_[0].state, FREE);
 }
 
 // Looks for a non-allocated block that is big enough. Search in the FREE

[Paweł Hajdan Jr., 2014-05-16 11:27:38]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:27:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jadahl@opera.com/282513003/20001

[commit-bot: I haz the power, 2014-05-16 11:29:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:29:01]

Failed to apply patch for @master/gpu/command_buffer/client/fenced_allocator.cc:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/gpu/command_buffer/client/fenced_allocator.cc
Index: gpu/command_buffer/client/fenced_allocator.cc
diff --git @master/gpu/command_buffer/client/fenced_allocator.cc
@master/gpu/command_buffer/client/fenced_allocator.cc
index
4e405e94e7ad5626094fe9fb91ec365f00189835..80038571be9fccf4e5274101e0959c33aa2586c9
100644
--- a/@master/gpu/command_buffer/client/fenced_allocator.cc
+++ b/@master/gpu/command_buffer/client/fenced_allocator.cc
@@ -50,9 +50,9 @@ FencedAllocator::~FencedAllocator() {
       i = WaitForTokenAndFreeBlock(i);
     }
   }
-  // These checks are not valid if the service has crashed or lost the context.
-  // DCHECK_EQ(blocks_.size(), 1u);
-  // DCHECK_EQ(blocks_[0].state, FREE);
+
+  DCHECK_EQ(blocks_.size(), 1u);
+  DCHECK_EQ(blocks_[0].state, FREE);
 }
 
 // Looks for a non-allocated block that is big enough. Search in the FREE

[Paweł Hajdan Jr., 2014-05-16 11:40:24]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:40:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jadahl@opera.com/282513003/20001

[commit-bot: I haz the power, 2014-05-16 11:41:42]

Change committed as 270991