gpu/command_buffer/client/gles2_implementation_unittest.cc - Issue 282513003: gpu: Assert that FencedAllocator is empty in destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 282513003: gpu: Assert that FencedAllocator is empty in destructor (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed 64 bit only test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/client/gles2_implementation_unittest.cc

diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc

index f7fbca4e41e49fddc99562fb9d8a26fe30acc1ea..a35f1f969c73dbb70e9e164426556c7bcf464644 100644

--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc

+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc

@@ -3275,9 +3275,11 @@ TEST_F(GLES2ImplementationTest, LimitSizeAndOffsetTo32Bit) {

EXPECT_STREQ(kSizeOverflowMessage, GetLastError().c_str());

// Call MapBufferSubDataCHROMIUM() should succeed with legal paramaters.

- EXPECT_TRUE(NULL != gl_->MapBufferSubDataCHROMIUM(

- GL_ARRAY_BUFFER, 0, 1, GL_WRITE_ONLY));

+ void* mem =

+ gl_->MapBufferSubDataCHROMIUM(GL_ARRAY_BUFFER, 0, 1, GL_WRITE_ONLY);

+ EXPECT_TRUE(NULL != mem);

EXPECT_EQ(GL_NO_ERROR, CheckError());

+ gl_->UnmapBufferSubDataCHROMIUM(mem);

// MapBufferSubDataCHROMIUM: offset

EXPECT_TRUE(NULL == gl_->MapBufferSubDataCHROMIUM(