[wasm] Fix DCHECK handiling pending exceptions.

[wasm] Fix DCHECK handiling pending exceptions.

+ additional fixes uncovered by bug, and addressed remaining feedback
from original CL (https://codereview.chromium.org/2806073002/).

Note that the regression test differs slightly from the bug reported one,
in that it catches the RangeError which will eventually be thrown due
to call stack size being exceeded.


BUG=chromium:712569
Review-Url: https://codereview.chromium.org/2825073002
Cr-Commit-Position: refs/heads/master@{#44700}
Committed: https://chromium.googlesource.com/v8/v8/+/9cc672911fc08925dcfda160afe2f0624f5af1cb

[Mircea Trofin, 2017-04-18 16:39:29]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 16:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 17:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 17:07:01]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2017-04-18 18:10:10]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:10:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-04-18 18:12:56]

Description was changed from

==========
[wasm] v8 APIs schedule pending exceptions.


BUG=chromium:712569
==========

to

==========
[wasm] v8 APIs schedule pending exceptions.

+ additional fixes uncovered by bug, and addressed remaining feedback
from original CL (https://codereview.chromium.org/2806073002/).

Note that the regression test differs slightly from the bug reported one,
in that it catches the RangeError which will eventually be thrown due
to call stack size being exceeded.


BUG=chromium:712569
==========

[Mircea Trofin, 2017-04-18 18:12:56]

mtrofin@chromium.org changed reviewers:
+ adamk@chromium.org, bradnelson@chromium.org

[adamk, 2017-04-18 18:19:05]

lgtm

[adamk, 2017-04-18 18:21:35]

One thing: could you make the CL description a little clearer? I'd expect the
first line to say what this CL changes, not what the state of the world is. So
it'd be something like "Fix DCHECK regarding pending exceptions", with detail
about pending/scheduled in the body of the description.

[Mircea Trofin, 2017-04-18 18:23:44]

Description was changed from

==========
[wasm] v8 APIs schedule pending exceptions.

+ additional fixes uncovered by bug, and addressed remaining feedback
from original CL (https://codereview.chromium.org/2806073002/).

Note that the regression test differs slightly from the bug reported one,
in that it catches the RangeError which will eventually be thrown due
to call stack size being exceeded.


BUG=chromium:712569
==========

to

==========
[wasm] Fix DCHECK handiling pending vs scheduled exceptions.

+ additional fixes uncovered by bug, and addressed remaining feedback
from original CL (https://codereview.chromium.org/2806073002/).

Note that the regression test differs slightly from the bug reported one,
in that it catches the RangeError which will eventually be thrown due
to call stack size being exceeded.


BUG=chromium:712569
==========

[Mircea Trofin, 2017-04-18 18:24:41]

Description was changed from

==========
[wasm] Fix DCHECK handiling pending vs scheduled exceptions.

+ additional fixes uncovered by bug, and addressed remaining feedback
from original CL (https://codereview.chromium.org/2806073002/).

Note that the regression test differs slightly from the bug reported one,
in that it catches the RangeError which will eventually be thrown due
to call stack size being exceeded.


BUG=chromium:712569
==========

to

==========
[wasm] Fix DCHECK handiling pending exceptions.

+ additional fixes uncovered by bug, and addressed remaining feedback
from original CL (https://codereview.chromium.org/2806073002/).

Note that the regression test differs slightly from the bug reported one,
in that it catches the RangeError which will eventually be thrown due
to call stack size being exceeded.


BUG=chromium:712569
==========

[Mircea Trofin, 2017-04-18 18:24:50]

On 2017/04/18 18:21:35, adamk wrote:
> One thing: could you make the CL description a little clearer? I'd expect the
> first line to say what this CL changes, not what the state of the world is. So
> it'd be something like "Fix DCHECK regarding pending exceptions", with detail
> about pending/scheduled in the body of the description.

Done - thanks!

[commit-bot: I haz the power, 2017-04-18 18:39:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 18:39:07]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2017-04-18 19:12:10]

The CQ bit was checked by mtrofin@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:12:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:15:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492542730129230,
"parent_rev": "5930e0ab393217e9a3da481bd2e80a886c4d7c90", "commit_rev":
"9cc672911fc08925dcfda160afe2f0624f5af1cb"}

[commit-bot: I haz the power, 2017-04-18 19:15:19]

Description was changed from

==========
[wasm] Fix DCHECK handiling pending exceptions.

+ additional fixes uncovered by bug, and addressed remaining feedback
from original CL (https://codereview.chromium.org/2806073002/).

Note that the regression test differs slightly from the bug reported one,
in that it catches the RangeError which will eventually be thrown due
to call stack size being exceeded.


BUG=chromium:712569
==========

to

==========
[wasm] Fix DCHECK handiling pending exceptions.

+ additional fixes uncovered by bug, and addressed remaining feedback
from original CL (https://codereview.chromium.org/2806073002/).

Note that the regression test differs slightly from the bug reported one,
in that it catches the RangeError which will eventually be thrown due
to call stack size being exceeded.


BUG=chromium:712569

Review-Url: https://codereview.chromium.org/2825073002
Cr-Commit-Position: refs/heads/master@{#44700}
Committed:
https://chromium.googlesource.com/v8/v8/+/9cc672911fc08925dcfda160afe2f0624f5...
==========

[commit-bot: I haz the power, 2017-04-18 19:15:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9cc672911fc08925dcfda160afe2f0624f5...