Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2825033002: [webnfc] Remove duplicate test case from layout test (Closed)

Created:
3 years, 8 months ago by shalamov
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] Remove duplicate test case from layout test This CL fixes one test case and removes one duplicate. BUG=711141 Review-Url: https://codereview.chromium.org/2825033002 Cr-Commit-Position: refs/heads/master@{#465209} Committed: https://chromium.googlesource.com/chromium/src/+/a2942673dd8357b4bc530973b5a3a645e574578c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M third_party/WebKit/LayoutTests/nfc/push.html View 1 chunk +1 line, -7 lines 1 comment Download

Messages

Total messages: 14 (8 generated)
shalamov
Could you please take a look (small fix)
3 years, 8 months ago (2017-04-18 10:39:51 UTC) #4
haraken
https://codereview.chromium.org/2825033002/diff/1/third_party/WebKit/LayoutTests/nfc/push.html File third_party/WebKit/LayoutTests/nfc/push.html (left): https://codereview.chromium.org/2825033002/diff/1/third_party/WebKit/LayoutTests/nfc/push.html#oldcode137 third_party/WebKit/LayoutTests/nfc/push.html:137: nfc.assertNFCMessagesEqual(test_buffer_data, nfc.mockNFC.pushedMessage()); Hmm? How was this test duplicated?
3 years, 8 months ago (2017-04-18 10:44:33 UTC) #5
shalamov
On 2017/04/18 10:44:33, haraken wrote: > https://codereview.chromium.org/2825033002/diff/1/third_party/WebKit/LayoutTests/nfc/push.html > File third_party/WebKit/LayoutTests/nfc/push.html (left): > > https://codereview.chromium.org/2825033002/diff/1/third_party/WebKit/LayoutTests/nfc/push.html#oldcode137 > ...
3 years, 8 months ago (2017-04-18 10:50:01 UTC) #6
haraken
LGTM
3 years, 8 months ago (2017-04-18 11:07:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825033002/1
3 years, 8 months ago (2017-04-18 12:44:15 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 12:49:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2942673dd8357b4bc530973b5a3...

Powered by Google App Engine
This is Rietveld 408576698