Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2825023002: [ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:alert_coordinator_internal to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:alert_coordinator_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2825023002 Cr-Commit-Position: refs/heads/master@{#465921} Committed: https://chromium.googlesource.com/chromium/src/+/709926262c235d357de56e60c4e5be8a64996046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M ios/chrome/browser/ui/alert_coordinator/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.mm View 11 chunks +30 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
gambard
PTAL as I am owner :)
3 years, 8 months ago (2017-04-18 09:29:14 UTC) #4
stkhapugin
lgtm
3 years, 8 months ago (2017-04-19 16:50:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825023002/1
3 years, 8 months ago (2017-04-19 16:51:27 UTC) #9
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
3 years, 8 months ago (2017-04-19 18:00:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825023002/1
3 years, 8 months ago (2017-04-20 06:43:07 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 06:46:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/709926262c235d357de56e60c4e5...

Powered by Google App Engine
This is Rietveld 408576698