Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/{a,b,c,d,e,f,g}*

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/{a,b,c,d,e,f,g}*

This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters.
The tool rewrites base::Bind to base::BindOnce where the resulting Callback
is immediately converted to OnceCallback.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback. 

BUG=554299
Review-Url: https://codereview.chromium.org/2825003002
Cr-Commit-Position: refs/heads/master@{#465863}
Committed: https://chromium.googlesource.com/chromium/src/+/29ea5c72b53e6155f6be77abcb7c65ed5187e122

[tzik, 2017-04-18 06:32:13]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 06:32:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-18 06:39:08]

Description was changed from

==========
Rewrite base::Bind to base::BindOnce with base_bind_rewriters in
//chrome/browser

This is a generated CL by a clang refactoring tool at
//tools/clang/base_bind_rewriters.
The tool rewrites base::Bind to base::BindOnce where the resulting Callback
is immediately converted to OnceCallback.

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback.

BUG=554299
==========

to

==========
Rewrite base::Bind to base::BindOnce with base_bind_rewriters in
//chrome/browser

This is a generated CL by a clang refactoring tool at
//tools/clang/base_bind_rewriters.
The tool rewrites base::Bind to base::BindOnce where the resulting Callback
is immediately converted to OnceCallback.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback. 

BUG=554299
==========

[tzik, 2017-04-18 06:41:05]

tzik@chromium.org changed reviewers:
+ sky@chromium.org

[tzik, 2017-04-18 06:54:03]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 06:54:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 07:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 07:49:19]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-04-18 11:56:33]

PTAL

[sky, 2017-04-18 16:17:47]

Oy, a review this big is too much for me to go through. I don't feel this review
can be given a rubber stamp either. Could you please split it up and send to
local owners?

[Bernhard Bauer, 2017-04-18 16:53:15]

FWIW, I glanced through c/b/supervised_user and c/b/ntp_suggestions, and
those LGTM.

On Tue, Apr 18, 2017 at 5:17 PM <sky@chromium.org> wrote:

> Oy, a review this big is too much for me to go through. I don't feel this
> review
> can be given a rubber stamp either. Could you please split it up and send
> to
> local owners?
>
> https://codereview.chromium.org/2825003002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "New Tab Page development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ntp-dev+unsubscribe@chromium.org.
> To post to this group, send email to ntp-dev@chromium.org.
> To view this discussion on the web visit
>
https://groups.google.com/a/chromium.org/d/msgid/ntp-dev/001a114f0c0c9aec0505...
>
<https://groups.google.com/a/chromium.org/d/msgid/ntp-dev/001a114f0c0c9aec0505...>
> .
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Bernhard Bauer, 2017-04-18 16:53:15]

FWIW, I glanced through c/b/supervised_user and c/b/ntp_suggestions, and
those LGTM.

On Tue, Apr 18, 2017 at 5:17 PM <sky@chromium.org> wrote:

> Oy, a review this big is too much for me to go through. I don't feel this
> review
> can be given a rubber stamp either. Could you please split it up and send
> to
> local owners?
>
> https://codereview.chromium.org/2825003002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "New Tab Page development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ntp-dev+unsubscribe@chromium.org.
> To post to this group, send email to ntp-dev@chromium.org.
> To view this discussion on the web visit
>
https://groups.google.com/a/chromium.org/d/msgid/ntp-dev/001a114f0c0c9aec0505...
>
<https://groups.google.com/a/chromium.org/d/msgid/ntp-dev/001a114f0c0c9aec0505...>
> .
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[skym, 2017-04-18 17:11:42]

skym@chromium.org changed reviewers:
+ skym@chromium.org

[skym, 2017-04-18 17:11:44]

c/b/sync/ and c/b/ui/sync/ lgtm

[msramek, 2017-04-18 17:39:18]

msramek@chromium.org changed reviewers:
+ msramek@chromium.org

[msramek, 2017-04-18 17:39:20]

Well, since you guys already started... :)

browsing_data/ and content_settings/ LGTM.

All changes are in PostTask(). I know of a few callbacks that should be
Repeated, and those were not changed.

[Lei Zhang, 2017-04-18 20:43:44]

On 2017/04/18 16:17:47, sky wrote:
> Oy, a review this big is too much for me to go through. I don't feel this
review
> can be given a rubber stamp either. Could you please split it up and send to
> local owners?

How about splitting off c/b/extensions, c/b/ui, and c/b/safe_browsing into their
own CLs?

[tzik, 2017-04-18 23:15:05]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 23:15:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 00:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 00:54:10]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-04-19 07:06:12]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 07:06:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 07:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 07:12:48]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tzik, 2017-04-19 07:17:41]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 07:18:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 07:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 07:24:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2017-04-19 08:21:07]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 08:21:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-19 08:43:57]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 08:44:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-19 08:51:48]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 08:52:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2017-04-19 08:55:30]

This time from Rietveld: c/b/supervised_user and c/b/ntp_suggestions LGTM.

[tzik, 2017-04-19 09:21:19]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 09:21:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-19 09:24:38]

Description was changed from

==========
Rewrite base::Bind to base::BindOnce with base_bind_rewriters in
//chrome/browser

This is a generated CL by a clang refactoring tool at
//tools/clang/base_bind_rewriters.
The tool rewrites base::Bind to base::BindOnce where the resulting Callback
is immediately converted to OnceCallback.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback. 

BUG=554299
==========

to

==========
Rewrite base::Bind to base::BindOnce with base_bind_rewriters in
//chrome/browser/{a,b,c,d,e,f,g}*

This is a generated CL by a clang refactoring tool at
//tools/clang/base_bind_rewriters.
The tool rewrites base::Bind to base::BindOnce where the resulting Callback
is immediately converted to OnceCallback.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback. 

BUG=554299
==========

[tzik, 2017-04-19 09:27:23]

On 2017/04/18 16:17:47, sky wrote:
> Oy, a review this big is too much for me to go through. I don't feel this
review
> can be given a rubber stamp either. Could you please split it up and send to
> local owners?

Ah, yes. It was surely too big. Sorry.
I've split it to pieces.

[tzik, 2017-04-19 09:34:38]

skym, msramek, bauerb: Thanks for reviewing this!

skym, msramek:
I moved c/b/sync/ part to http://crrev.com/2830603002/, and c/b/browsing_data/
to http://crrev.com/2826783003/.
As the other CLs are subsets of this one, let me mark them as TBR per your
review in this CL.

[tzik, 2017-04-19 09:35:35]

On 2017/04/18 20:43:44, Lei Zhang wrote:
> On 2017/04/18 16:17:47, sky wrote:
> > Oy, a review this big is too much for me to go through. I don't feel this
> review
> > can be given a rubber stamp either. Could you please split it up and send to
> > local owners?
> 
> How about splitting off c/b/extensions, c/b/ui, and c/b/safe_browsing into
their
> own CLs?

Done! I split the CL for them and other directories.

[commit-bot: I haz the power, 2017-04-19 10:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 10:17:52]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-19 16:02:38]

Thanks for splitting up. LGTM

[tzik, 2017-04-20 02:09:32]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-04-20 02:09:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
msramek@chromium.org, skym@chromium.org, bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2825003002/#ps150001
(title: "split rest of changes to 3 CLs")

[commit-bot: I haz the power, 2017-04-20 02:10:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 02:16:55]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1492654172694610,
"parent_rev": "c171743506f956192f93e27cc4d5bd0ff0adad33", "commit_rev":
"29ea5c72b53e6155f6be77abcb7c65ed5187e122"}

[commit-bot: I haz the power, 2017-04-20 02:17:06]

Description was changed from

==========
Rewrite base::Bind to base::BindOnce with base_bind_rewriters in
//chrome/browser/{a,b,c,d,e,f,g}*

This is a generated CL by a clang refactoring tool at
//tools/clang/base_bind_rewriters.
The tool rewrites base::Bind to base::BindOnce where the resulting Callback
is immediately converted to OnceCallback.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback. 

BUG=554299
==========

to

==========
Rewrite base::Bind to base::BindOnce with base_bind_rewriters in
//chrome/browser/{a,b,c,d,e,f,g}*

This is a generated CL by a clang refactoring tool at
//tools/clang/base_bind_rewriters.
The tool rewrites base::Bind to base::BindOnce where the resulting Callback
is immediately converted to OnceCallback.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback. 

BUG=554299

Review-Url: https://codereview.chromium.org/2825003002
Cr-Commit-Position: refs/heads/master@{#465863}
Committed:
https://chromium.googlesource.com/chromium/src/+/29ea5c72b53e6155f6be77abcb7c...
==========

[commit-bot: I haz the power, 2017-04-20 02:17:09]

Committed patchset #10 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/29ea5c72b53e6155f6be77abcb7c...