Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: net/cert/ct_objects_extractor.h

Issue 2824983002: Rename net::ct::LogEntry to SignedEntryData and clarify the comment. (Closed)
Patch Set: sort forward decls Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/ct_log_verifier_unittest.cc ('k') | net/cert/ct_objects_extractor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_objects_extractor.h
diff --git a/net/cert/ct_objects_extractor.h b/net/cert/ct_objects_extractor.h
index d5deb5b607e3fbbbfa7c67d550e221d8967ae971..469e315daddfce02b71ffbf630f326e157c62cf5 100644
--- a/net/cert/ct_objects_extractor.h
+++ b/net/cert/ct_objects_extractor.h
@@ -15,7 +15,7 @@ namespace net {
namespace ct {
-struct LogEntry;
+struct SignedEntryData;
// Extracts a SignedCertificateTimestampList that has been embedded within a
// leaf cert as an X.509v3 extension with the OID 1.3.6.1.4.1.11129.2.4.2.
@@ -33,9 +33,10 @@ NET_EXPORT_PRIVATE bool ExtractEmbeddedSCTList(
// The filled |*result| should be verified using ct::CTLogVerifier::Verify
// Note: If |leaf| does not contain the required extension, it is treated as
// a failure.
-NET_EXPORT_PRIVATE bool GetPrecertLogEntry(X509Certificate::OSCertHandle leaf,
- X509Certificate::OSCertHandle issuer,
- LogEntry* result);
+NET_EXPORT_PRIVATE bool GetPrecertSignedEntry(
+ X509Certificate::OSCertHandle leaf,
+ X509Certificate::OSCertHandle issuer,
+ SignedEntryData* result);
// Obtains an X509Chain log entry for |leaf|, an X.509v3 certificate that
// is not expected to contain an X.509v3 extension with the OID
@@ -43,8 +44,8 @@ NET_EXPORT_PRIVATE bool GetPrecertLogEntry(X509Certificate::OSCertHandle leaf,
// On success, fills |result| with the data for an X509Chain log entry and
// returns true.
// The filled |*result| should be verified using ct::CTLogVerifier::Verify
-NET_EXPORT_PRIVATE bool GetX509LogEntry(X509Certificate::OSCertHandle leaf,
- LogEntry* result);
+NET_EXPORT_PRIVATE bool GetX509SignedEntry(X509Certificate::OSCertHandle leaf,
+ SignedEntryData* result);
// Extracts a SignedCertificateTimestampList that has been embedded within
// an OCSP response as an extension with the OID 1.3.6.1.4.1.11129.2.4.5.
« no previous file with comments | « net/cert/ct_log_verifier_unittest.cc ('k') | net/cert/ct_objects_extractor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698