Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: net/cert/ct_objects_extractor.cc

Issue 2824983002: Rename net::ct::LogEntry to SignedEntryData and clarify the comment. (Closed)
Patch Set: sort forward decls Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/ct_objects_extractor.h ('k') | net/cert/ct_objects_extractor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_objects_extractor.cc
diff --git a/net/cert/ct_objects_extractor.cc b/net/cert/ct_objects_extractor.cc
index 1a6e6e4772d63a4dd924e11220ef4b5f934d4a10..7c9eb719ee7dde3f84af837b106a8623bb06c2ff 100644
--- a/net/cert/ct_objects_extractor.cc
+++ b/net/cert/ct_objects_extractor.cc
@@ -173,9 +173,9 @@ bool ExtractEmbeddedSCTList(X509Certificate::OSCertHandle cert,
sct_list);
}
-bool GetPrecertLogEntry(X509Certificate::OSCertHandle leaf,
- X509Certificate::OSCertHandle issuer,
- LogEntry* result) {
+bool GetPrecertSignedEntry(X509Certificate::OSCertHandle leaf,
+ X509Certificate::OSCertHandle issuer,
+ SignedEntryData* result) {
result->Reset();
bssl::UniquePtr<X509> leaf_x509(OSCertHandleToOpenSSL(leaf));
@@ -228,8 +228,8 @@ bool GetPrecertLogEntry(X509Certificate::OSCertHandle leaf,
if (!asn1::ExtractSPKIFromDERCert(issuer_der, &issuer_key))
return false;
- // Fill in the LogEntry.
- result->type = ct::LogEntry::LOG_ENTRY_TYPE_PRECERT;
+ // Fill in the SignedEntryData.
+ result->type = ct::SignedEntryData::LOG_ENTRY_TYPE_PRECERT;
result->tbs_certificate.swap(to_be_signed);
crypto::SHA256HashString(issuer_key, result->issuer_key_hash.data,
sizeof(result->issuer_key_hash.data));
@@ -237,7 +237,8 @@ bool GetPrecertLogEntry(X509Certificate::OSCertHandle leaf,
return true;
}
-bool GetX509LogEntry(X509Certificate::OSCertHandle leaf, LogEntry* result) {
+bool GetX509SignedEntry(X509Certificate::OSCertHandle leaf,
+ SignedEntryData* result) {
DCHECK(leaf);
std::string encoded;
@@ -245,7 +246,7 @@ bool GetX509LogEntry(X509Certificate::OSCertHandle leaf, LogEntry* result) {
return false;
result->Reset();
- result->type = ct::LogEntry::LOG_ENTRY_TYPE_X509;
+ result->type = ct::SignedEntryData::LOG_ENTRY_TYPE_X509;
result->leaf_certificate.swap(encoded);
return true;
}
« no previous file with comments | « net/cert/ct_objects_extractor.h ('k') | net/cert/ct_objects_extractor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698