Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2824943005: chromeos: Add org.chromium.NetworkProxyService D-Bus service. (Closed)

Created:
3 years, 8 months ago by Daniel Erat
Modified:
3 years, 8 months ago
Reviewers:
teravest
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Add org.chromium.NetworkProxyService D-Bus service. Add a new D-Bus service with a ResolveProxy method that duplicates the existing ResolveNetworkProxy method exported on org.chromium.LibCrosService. BUG=703217 Review-Url: https://codereview.chromium.org/2824943005 Cr-Commit-Position: refs/heads/master@{#465385} Committed: https://chromium.googlesource.com/chromium/src/+/7cdbe9d94a27496d2b37dd0cca89d6be392f003f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 5 chunks +16 lines, -0 lines 0 comments Download
M chromeos/dbus/services/proxy_resolution_service_provider.h View 2 chunks +5 lines, -1 line 0 comments Download
M chromeos/dbus/services/proxy_resolution_service_provider.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Daniel Erat
3 years, 8 months ago (2017-04-18 19:27:27 UTC) #2
teravest
lgtm
3 years, 8 months ago (2017-04-18 20:16:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824943005/1
3 years, 8 months ago (2017-04-18 21:33:47 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:40:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7cdbe9d94a27496d2b37dd0cca89...

Powered by Google App Engine
This is Rietveld 408576698