Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2824883007: Fix wrong inclusion of .cc file in policy/ (Closed)

Created:
3 years, 8 months ago by emaxx
Modified:
3 years, 8 months ago
Reviewers:
Ivan Šandrk
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong inclusion of .cc file in policy/ BUG=713138 Review-Url: https://codereview.chromium.org/2824883007 Cr-Commit-Position: refs/heads/master@{#465581} Committed: https://chromium.googlesource.com/chromium/src/+/7a726a72d1a958dc24579fbe7d191ef11ad18357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824883007/1
3 years, 8 months ago (2017-04-19 12:20:03 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-19 12:20:05 UTC) #8
emaxx
isandrk@: PTAL.
3 years, 8 months ago (2017-04-19 12:30:40 UTC) #10
Ivan Šandrk
On 2017/04/19 12:30:40, emaxx wrote: > isandrk@: PTAL. lol nice catch, this kind of thing ...
3 years, 8 months ago (2017-04-19 13:30:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824883007/1
3 years, 8 months ago (2017-04-19 13:33:47 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 13:38:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a726a72d1a958dc24579fbe7d19...

Powered by Google App Engine
This is Rietveld 408576698