Scopeless matching of :host rules for style sharing.

Scopeless matching of :host rules for style sharing.

The kSharingRules mode for selector matching needs to bypass scope
checking in various places because we match selectors from the set of
global uncommon attribute rules for which the source scope is unknown.

We should really store these rules per scope, at least for Shadow DOM
v1, and pass the correct scope for matching.

BUG=711539
Review-Url: https://codereview.chromium.org/2824853004
Cr-Commit-Position: refs/heads/master@{#465980}
Committed: https://chromium.googlesource.com/chromium/src/+/0e2caa4b6dc7715e9d08e77f46e1dcdf28825405

[rune, 2017-04-18 15:24:53]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 15:25:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 17:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 17:03:34]

Dry run: This issue passed the CQ dry run.

[rune, 2017-04-18 23:12:56]

rune@opera.com changed reviewers:
+ kochi@chromium.org

[rune, 2017-04-18 23:12:57]

ptal

[kochi, 2017-04-19 10:21:12]

(first round comment only, will take closer look tomorrow)

https://codereview.chromium.org/2824853004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/2824853004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:344: for
(next_context.element = ParentElement(next_context);
This looks like a bug, but is this for bug 711539?

https://codereview.chromium.org/2824853004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:362: next_context.element
= ParentElement(next_context);
Ditto

[rune, 2017-04-19 22:49:47]

https://codereview.chromium.org/2824853004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/2824853004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:344: for
(next_context.element = ParentElement(next_context);
On 2017/04/19 10:21:12, kochi wrote:
> This looks like a bug, but is this for bug 711539?

The element is initially the same for context and next_context, so it doesn't
matter. The reason I changed which to start from was that I wanted to modify the
scope member and context was const.

[kochi, 2017-04-20 10:45:21]

Thanks for the explanation.  LGTM

https://codereview.chromium.org/2824853004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/2824853004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:344: for
(next_context.element = ParentElement(next_context);
On 2017/04/19 22:49:47, rune wrote:
> On 2017/04/19 10:21:12, kochi wrote:
> > This looks like a bug, but is this for bug 711539?
> 
> The element is initially the same for context and next_context, so it doesn't
> matter. The reason I changed which to start from was that I wanted to modify
the
> scope member and context was const.

Acknowledged.

[rune, 2017-04-20 10:52:19]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-04-20 10:52:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 12:20:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492685539388240, "parent_rev":
"faa3495a7a1032e994a62ddb6009b23f2ac5a33c", "commit_rev":
"0e2caa4b6dc7715e9d08e77f46e1dcdf28825405"}

[commit-bot: I haz the power, 2017-04-20 12:21:05]

Description was changed from

==========
Scopeless matching of :host rules for style sharing.

The kSharingRules mode for selector matching needs to bypass scope
checking in various places because we match selectors from the set of
global uncommon attribute rules for which the source scope is unknown.

We should really store these rules per scope, at least for Shadow DOM
v1, and pass the correct scope for matching.

BUG=711539
==========

to

==========
Scopeless matching of :host rules for style sharing.

The kSharingRules mode for selector matching needs to bypass scope
checking in various places because we match selectors from the set of
global uncommon attribute rules for which the source scope is unknown.

We should really store these rules per scope, at least for Shadow DOM
v1, and pass the correct scope for matching.

BUG=711539

Review-Url: https://codereview.chromium.org/2824853004
Cr-Commit-Position: refs/heads/master@{#465980}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e2caa4b6dc7715e9d08e77f46e1...
==========

[commit-bot: I haz the power, 2017-04-20 12:21:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e2caa4b6dc7715e9d08e77f46e1...