Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2824833002:
Explicitly disable WebGL2 where D3D11 is disabled. (Closed)
|
Created:
3 years, 8 months ago by Zhenyao Mo Modified:
3 years, 8 months ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionExplicitly disable WebGL2 where D3D11 is disabled.
BUG=706366
TEST=gpu_unittests
R=capn@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2824833002
Cr-Commit-Position: refs/heads/master@{#465278}
Committed: https://chromium.googlesource.com/chromium/src/+/14d57a734d7f70b2087ed8db3b833c47d3c7df13
Patch Set 1 #
Messages
Total messages: 24 (12 generated)
Description was changed from ========== Explicitly disable WebGL2 where D3D11 is disabled. BUG=706366 TEST=gpu_unittests R=capn@chromium.org ========== to ========== Explicitly disable WebGL2 where D3D11 is disabled. BUG=706366 TEST=gpu_unittests R=capn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by zmo@chromium.org to run a CQ dry run
capn: PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/04/18 16:49:48, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. What?! you are not a chromium committer?
Description was changed from ========== Explicitly disable WebGL2 where D3D11 is disabled. BUG=706366 TEST=gpu_unittests R=capn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Explicitly disable WebGL2 where D3D11 is disabled. BUG=706366 TEST=gpu_unittests R=capn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
zmo@chromium.org changed reviewers: + geofflang@chromium.org
geoff, can you review this? I copied all entries from gpu_driver_bug_list.json
lgtm Are we still disabling D3D11 too or are we leaving it up to ANGLE to fail D3D11 initialization in these cases?
On 2017/04/18 17:21:25, Geoff Lang wrote: > lgtm > > Are we still disabling D3D11 too or are we leaving it up to ANGLE to fail D3D11 > initialization in these cases? We are still explicitly disabling D3D11 through gpu_driver_bug_list.json.
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492536307291570, "parent_rev":
"d5b8fd95f089f4da5e250845fef20a0b42f96582", "commit_rev":
"14d57a734d7f70b2087ed8db3b833c47d3c7df13"}
Message was sent while issue was closed.
Description was changed from ========== Explicitly disable WebGL2 where D3D11 is disabled. BUG=706366 TEST=gpu_unittests R=capn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Explicitly disable WebGL2 where D3D11 is disabled. BUG=706366 TEST=gpu_unittests R=capn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2824833002 Cr-Commit-Position: refs/heads/master@{#465278} Committed: https://chromium.googlesource.com/chromium/src/+/14d57a734d7f70b2087ed8db3b83... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/14d57a734d7f70b2087ed8db3b83...
Message was sent while issue was closed.
On 2017/04/18 at 17:17:53, zmo wrote: > On 2017/04/18 16:49:48, commit-bot: I haz the power wrote: > > No L-G-T-M from a valid reviewer yet. > > CQ run can only be started once the patch has received an L-G-T-M from a full > > committer. > > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > > full super star committer. > > Committers are members of the group "project-chromium-committers". > > Note that this has nothing to do with OWNERS files. > > What?! you are not a chromium committer? No, I've spent very little time in the Chromium source base so far. Most of my changes have been in the SwiftShader, ANGLE, and Android repositories.
Message was sent while issue was closed.
I'm a committer but I don't own this file. :( |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
