Implement BrowserWindowCocoa::IsToolbarShowing

Implement BrowserWindowCocoa::IsToolbarShowing

According to the discussion in http://crbug.com/702251, we would prefer to only
disable browser keyboard shortcuts once the toolbar is hidden in fullscreen
mode on Mac. So a new function IsToolbarShowing() is added to BrowserWindow
interface.
This change implements this function in BrowserWindowCocoa by retrieving
information from BrowserWindowController.

R=shrike@chromium.org
CC=msw@chromium.org

BUG=680809
Review-Url: https://codereview.chromium.org/2824803004
Cr-Commit-Position: refs/heads/master@{#467141}
Committed: https://chromium.googlesource.com/chromium/src/+/901f389a22a01c1c2bbee6b665685a8db123e70e

[Hzj_jie, 2017-04-17 22:56:24]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 22:56:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 23:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 23:26:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hzj_jie, 2017-04-21 22:03:48]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 22:04:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2017-04-21 22:07:49]

Patchset #2 (id:20001) has been deleted

[Hzj_jie, 2017-04-21 22:07:58]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-21 22:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 22:25:29]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-04-21 22:32:17]

Description was changed from

==========
Implement isToolbarShowing

BUG=680809
==========

to

==========
Implement BrowserWindowCocoa::isToolbarShowing

According to the discussion in http://crbug.com/702251, we would prefer to only
disable browser keyboard shortcuts once the toolbar is hidden in fullscreen
mode on Mac. So a new function IsToolbarShowing() is added to BrowserWindow
interface.
This change implements this function in BrowserWindowCocoa by retrieving
information from BrowserWindowController.

R=shrike@chromium.org
CC=msw@chromium.org

BUG=680809
==========

[Hzj_jie, 2017-04-21 22:32:36]

zijiehe@chromium.org changed reviewers:
+ shrike@chromium.org

[Hzj_jie, 2017-04-25 01:33:57]

On 2017/04/21 22:32:55, Hzj_jie wrote:

Jayson, do you happen to know who could review this change?

[shrike, 2017-04-25 18:23:52]

On 2017/04/25 01:33:57, Hzj_jie wrote:
> On 2017/04/21 22:32:55, Hzj_jie wrote:
> 
> Jayson, do you happen to know who could review this change?

spqchan@ should take a look.

[Hzj_jie, 2017-04-25 19:22:23]

zijiehe@chromium.org changed reviewers:
+ spqchan@chromium.org

[Hzj_jie, 2017-04-25 19:22:57]

Add Sarah.

[spqchan, 2017-04-25 19:36:54]

lgtm

[Hzj_jie, 2017-04-25 21:29:45]

zijiehe@chromium.org changed reviewers:
+ rsesek@chromium.org

[Hzj_jie, 2017-04-25 21:30:10]

I may still need an LGTM from OWNERS of cocoa.

[Robert Sesek, 2017-04-25 21:31:46]

LGTM, but please fix capitalization in the CL description (isToolbarShowing).

[Hzj_jie, 2017-04-25 22:11:05]

Description was changed from

==========
Implement BrowserWindowCocoa::isToolbarShowing

According to the discussion in http://crbug.com/702251, we would prefer to only
disable browser keyboard shortcuts once the toolbar is hidden in fullscreen
mode on Mac. So a new function IsToolbarShowing() is added to BrowserWindow
interface.
This change implements this function in BrowserWindowCocoa by retrieving
information from BrowserWindowController.

R=shrike@chromium.org
CC=msw@chromium.org

BUG=680809
==========

to

==========
Implement BrowserWindowCocoa::IsToolbarShowing

According to the discussion in http://crbug.com/702251, we would prefer to only
disable browser keyboard shortcuts once the toolbar is hidden in fullscreen
mode on Mac. So a new function IsToolbarShowing() is added to BrowserWindow
interface.
This change implements this function in BrowserWindowCocoa by retrieving
information from BrowserWindowController.

R=shrike@chromium.org
CC=msw@chromium.org

BUG=680809
==========

[Hzj_jie, 2017-04-25 22:11:15]

On 2017/04/25 21:31:46, Robert Sesek wrote:
> LGTM, but please fix capitalization in the CL description (isToolbarShowing).

Done.

[Hzj_jie, 2017-04-25 22:12:23]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:13:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:34:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493158343187450,
"parent_rev": "0d82bd087c59ddb5f77a0ee314ab2c2e670cc3f3", "commit_rev":
"901f389a22a01c1c2bbee6b665685a8db123e70e"}

[commit-bot: I haz the power, 2017-04-25 22:34:17]

Description was changed from

==========
Implement BrowserWindowCocoa::IsToolbarShowing

According to the discussion in http://crbug.com/702251, we would prefer to only
disable browser keyboard shortcuts once the toolbar is hidden in fullscreen
mode on Mac. So a new function IsToolbarShowing() is added to BrowserWindow
interface.
This change implements this function in BrowserWindowCocoa by retrieving
information from BrowserWindowController.

R=shrike@chromium.org
CC=msw@chromium.org

BUG=680809
==========

to

==========
Implement BrowserWindowCocoa::IsToolbarShowing

According to the discussion in http://crbug.com/702251, we would prefer to only
disable browser keyboard shortcuts once the toolbar is hidden in fullscreen
mode on Mac. So a new function IsToolbarShowing() is added to BrowserWindow
interface.
This change implements this function in BrowserWindowCocoa by retrieving
information from BrowserWindowController.

R=shrike@chromium.org
CC=msw@chromium.org

BUG=680809

Review-Url: https://codereview.chromium.org/2824803004
Cr-Commit-Position: refs/heads/master@{#467141}
Committed:
https://chromium.googlesource.com/chromium/src/+/901f389a22a01c1c2bbee6b66568...
==========

[commit-bot: I haz the power, 2017-04-25 22:34:18]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/901f389a22a01c1c2bbee6b66568...