Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2824753005: Rename HostWindow to PlatformChromeClient (Closed)

Created:
3 years, 8 months ago by joelhockey
Modified:
3 years, 8 months ago
Reviewers:
slangley, haraken
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, dshwang, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, Navid Zolghadr, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename HostWindow to PlatformChromeClient BUG=637460 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2824753005 Cr-Commit-Position: refs/heads/master@{#465831} Committed: https://chromium.googlesource.com/chromium/src/+/bc84bc20b19ab8b91c31271ad10dc0687c2c6612

Patch Set 1 #

Patch Set 2 : Fix forward decl order #

Patch Set 3 : Fix BUILD.gn #

Patch Set 4 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -159 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/DevToolsHost.cpp View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/SpatialNavigation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/HostWindow.h View 1 chunk +0 lines, -64 lines 0 comments Download
A + third_party/WebKit/Source/platform/PlatformChromeClient.h View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 1 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (19 generated)
joelhockey
3 years, 8 months ago (2017-04-19 11:12:21 UTC) #3
haraken
LGTM (I'm not planning to bike-shed class names, but according to our frame arch refactoring ...
3 years, 8 months ago (2017-04-19 11:17:25 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2829613002 Patch 1). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-19 11:23:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824753005/40001
3 years, 8 months ago (2017-04-19 12:29:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/400019)
3 years, 8 months ago (2017-04-19 12:50:55 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824753005/60001
3 years, 8 months ago (2017-04-19 22:52:39 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 00:48:33 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bc84bc20b19ab8b91c31271ad10d...

Powered by Google App Engine
This is Rietveld 408576698