Make V4L2 Jpeg Decode Accelerator not compiled on an Intel device

Make V4L2 Jpeg Decode Accelerator not compiled on an Intel device

On an Intel device, V4L2JDA isn't used.
This patch makes V4L2JDA be not compiled if it's in an Intel device.

BUG=710729
TEST=confirm jpeg_accelerator_unittest is passed on x86_64 and armv7l.
Also appr.tc/?debug=loopback.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2824743002
Cr-Commit-Position: refs/heads/master@{#465554}
Committed: https://chromium.googlesource.com/chromium/src/+/eea08e1d749a5e8e21272e5cb281d4fdd7d7f214

[hiroh, 2017-04-17 07:42:54]

Description was changed from

==========
Make V4L2 Jpeg Decode Accelerator not compiled on an Intel device

On an Intel device, V4L2JDA isn't used.
This patch makes V4L2JDA be not compiled if it's in an Intel device.

BUG=710729
TEST=confirm jpeg_accelerator_unittest is passed on x86_64 and armv7l.
Also appr.tc/?debug=loopback.
==========

to

==========
Make V4L2 Jpeg Decode Accelerator not compiled on an Intel device

On an Intel device, V4L2JDA isn't used.
This patch makes V4L2JDA be not compiled if it's in an Intel device.

BUG=710729
TEST=confirm jpeg_accelerator_unittest is passed on x86_64 and armv7l.
Also appr.tc/?debug=loopback.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[hiroh, 2017-04-17 08:29:19]

Description was changed from

==========
Make V4L2 Jpeg Decode Accelerator not compiled on an Intel device

On an Intel device, V4L2JDA isn't used.
This patch makes V4L2JDA be not compiled if it's in an Intel device.

BUG=710729
TEST=confirm jpeg_accelerator_unittest is passed on x86_64 and armv7l.
Also appr.tc/?debug=loopback.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make V4L2 Jpeg Decode Accelerator not compiled on an Intel device

On an Intel device, V4L2JDA isn't used.
This patch makes V4L2JDA be not compiled if it's in an Intel device.

BUG=710729
TEST=confirm jpeg_accelerator_unittest is passed on x86_64 and armv7l.
Also appr.tc/?debug=loopback.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[hiroh, 2017-04-17 08:29:19]

hiroh@chromium.org changed reviewers:
+ posciak@chromium.org

[Pawel Osciak, 2017-04-17 08:49:21]

https://codereview.chromium.org/2824743002/diff/20001/media/gpu/ipc/service/g...
File media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc (right):

https://codereview.chromium.org/2824743002/diff/20001/media/gpu/ipc/service/g...
media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc:37: #include
"media/gpu/v4l2_device.h"
In this context v4l2jda is the only user of v4l2_device, so this file would not
be needed if v4l2jda wasn't used.

So I think this should be together with v4l2jda include in the "if !defined"
clause? Perhaps we could also merge USE_V4L2_CODEC and the v4l2jda clause
together in one ifdef then?

https://codereview.chromium.org/2824743002/diff/20001/media/gpu/ipc/service/g...
media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc:39: #if
!defined(ARCH_CPU_X86_FAMILY)
We should try to have this rule match our gn configuration.

If we say "if (!x86)" here, we should also say "if (!x86)" in gn file, or, if we
say "if (arm)" in gn file, we should also say "if (arm)" here.

Otherwise we may get errors in case we potentially compile for an arch that is
not an x86 and not an arm.

https://codereview.chromium.org/2824743002/diff/20001/media/gpu/ipc/service/g...
media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc:362: #if
!defined(ARCH_CPU_X86_FAMILY)
For vaapi we do this in CreateVaapiJDA call itself, instead of here.
It would be preferable to keep things consistent and do the same thing in both
cases.

I agree that it would probably be good not to have this push_back for unused
methods, so perhaps we could do what you did for CreateV4L2JDA for
CreateVaapiJDA as well please.

[Pawel Osciak, 2017-04-19 08:41:59]

lgtm

[hiroh, 2017-04-19 08:56:24]

The CQ bit was checked by hiroh@chromium.org

[commit-bot: I haz the power, 2017-04-19 08:56:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 11:13:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492592184908040,
"parent_rev": "b9725a0c5358b4900b1225efd907c6f3022f7308", "commit_rev":
"eea08e1d749a5e8e21272e5cb281d4fdd7d7f214"}

[commit-bot: I haz the power, 2017-04-19 11:13:39]

Description was changed from

==========
Make V4L2 Jpeg Decode Accelerator not compiled on an Intel device

On an Intel device, V4L2JDA isn't used.
This patch makes V4L2JDA be not compiled if it's in an Intel device.

BUG=710729
TEST=confirm jpeg_accelerator_unittest is passed on x86_64 and armv7l.
Also appr.tc/?debug=loopback.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make V4L2 Jpeg Decode Accelerator not compiled on an Intel device

On an Intel device, V4L2JDA isn't used.
This patch makes V4L2JDA be not compiled if it's in an Intel device.

BUG=710729
TEST=confirm jpeg_accelerator_unittest is passed on x86_64 and armv7l.
Also appr.tc/?debug=loopback.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2824743002
Cr-Commit-Position: refs/heads/master@{#465554}
Committed:
https://chromium.googlesource.com/chromium/src/+/eea08e1d749a5e8e21272e5cb281...
==========

[commit-bot: I haz the power, 2017-04-19 11:13:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eea08e1d749a5e8e21272e5cb281...