Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: components/arc/common/voice_interaction_framework.mojom

Issue 2824703006: Add MetalayerMode to the palette. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/common/voice_interaction_framework.mojom
diff --git a/components/arc/common/voice_interaction_framework.mojom b/components/arc/common/voice_interaction_framework.mojom
index adf25f4bd92eb50fc84803f0ba7d156aa2c54167..9af2b64a13c9776e90ddb3d20e68cfa2fe3cbc0c 100644
--- a/components/arc/common/voice_interaction_framework.mojom
+++ b/components/arc/common/voice_interaction_framework.mojom
@@ -2,14 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
-// Next MinVersion: 2
+// Next MinVersion: 3
module arc.mojom;
import "screen_rect.mojom";
// Handles voice interaction queries from Android.
-// Next method ID: 2
+// Next method ID: 3
interface VoiceInteractionFrameworkHost {
// Returns a screenshot of currently focused window or empty array if
// no window is focused.
@@ -17,10 +17,13 @@ interface VoiceInteractionFrameworkHost {
// Returns a fullscreen screenshot of the primary display.
[MinVersion=1]CaptureFullscreen@1() => (array<uint8> png_data);
+
+ // Notifies the host that the metalayer has closed.
+ [MinVersion=2]OnMetalayerComplete@2();
Luis Héctor Chávez 2017/04/19 15:48:29 maybe OnMetalayerVisibilityUpdated?
Vladislav Kaznacheev 2017/04/19 23:42:59 This is only required to notify the host that the
Luis Héctor Chávez 2017/04/20 16:03:26 Still, "MetalayerComplete" seems like an odd name.
Vladislav Kaznacheev 2017/04/20 17:54:55 Done.
};
// Connects with Android system server.
-// Next method ID:4
+// Next method ID: 5
interface VoiceInteractionFrameworkInstance {
Init@0(VoiceInteractionFrameworkHost host_ptr);
@@ -31,6 +34,9 @@ interface VoiceInteractionFrameworkInstance {
// selected.
[MinVersion=1] StartVoiceInteractionSessionForRegion@2(ScreenRect region);
- // Toggles the metalayer.
+ // Toggles the metalayer. Deprecated, use ShowMetalayer instead.
[MinVersion=1] ToggleMetalayer@3();
Luis Héctor Chávez 2017/04/19 15:48:29 You don't need to deprecate this :D [MinVersion=1
Vladislav Kaznacheev 2017/04/19 23:42:59 Done.
+
+ // Shows/hides the metalayer in the container.
+ [MinVersion=2] ShowMetalayer@4(bool visible);
};

Powered by Google App Engine
This is Rietveld 408576698