[Reland] Fix flaky NPE in oobe.js.

[Reland] Fix flaky NPE in oobe.js.

Under some racy condition, telemetry accesses the DOM object before ready.
This CL observes a new variable which is set to true when DOM is ready.

BUG=chromium:709041
TEST=Ran try. Ran on ChromeOS device with corresponding CL.

Review-Url: https://codereview.chromium.org/2824703003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/49eb11f63eb4d552d634833a01d2710208ba0523

[hidehiko, 2017-04-17 08:09:25]

hidehiko@chromium.org changed reviewers:
+ achuith@chromium.org

[hidehiko, 2017-04-17 08:09:26]

This needs to be landed after https://codereview.chromium.org/2825453002/.

achuith@, PTAL?

Thanks,
- hidehiko

[achuithb, 2017-04-17 08:42:58]

https://codereview.chromium.org/2824703003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/oobe.py (right):

https://codereview.chromium.org/2824703003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/oobe.py:41: "typeof Oobe ==
'function' && Oobe.readyForTesting !== null",
I think we should just test for Oobe.readyForTesting and not deal with the fact
that readyForTesting could be null, or false, or true.

[hidehiko, 2017-04-17 09:33:37]

Thank you for review!

Updated along with the depending CL change. PTAL.

https://codereview.chromium.org/2824703003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/oobe.py (right):

https://codereview.chromium.org/2824703003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/oobe.py:41: "typeof Oobe ==
'function' && Oobe.readyForTesting !== null",
On 2017/04/17 08:42:58, achuithb wrote:
> I think we should just test for Oobe.readyForTesting and not deal with the
fact
> that readyForTesting could be null, or false, or true.

Done.

[achuithb, 2017-04-17 18:40:59]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2017-04-17 18:40:59]

lgtm

[commit-bot: I haz the power, 2017-04-17 18:41:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-04-17 18:41:05]

The CQ bit was unchecked by achuith@chromium.org

[hidehiko, 2017-04-18 03:32:53]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2017-04-18 03:32:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 03:56:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492486373790670,
"parent_rev": "f7bb286d01fdbedf1f6dd5921d564ef5f0344cb4", "commit_rev":
"49eb11f63eb4d552d634833a01d2710208ba0523"}

[commit-bot: I haz the power, 2017-04-18 03:56:36]

Description was changed from

==========
[Reland] Fix flaky NPE in oobe.js.

Under some racy condition, telemetry accesses the DOM object before ready.
This CL observes a new variable which is set to true when DOM is ready.

BUG=chromium:709041
TEST=Ran try. Ran on ChromeOS device with corresponding CL.
==========

to

==========
[Reland] Fix flaky NPE in oobe.js.

Under some racy condition, telemetry accesses the DOM object before ready.
This CL observes a new variable which is set to true when DOM is ready.

BUG=chromium:709041
TEST=Ran try. Ran on ChromeOS device with corresponding CL.

Review-Url: https://codereview.chromium.org/2824703003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-04-18 03:56:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...