Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2824683002: Refactor FindScrollLayerForDeviceViewportPoint to use scroll nodes over layer ids (Closed)

Created:
3 years, 8 months ago by pdr.
Modified:
3 years, 8 months ago
Reviewers:
weiliangc, wkorman
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor FindScrollLayerForDeviceViewportPoint to use scroll nodes over layer ids This patch refactors FindScrollLayerForDeviceViewportPoint as FindScrollNodeForDeviceViewportPoint which both simplifies code and lets us remove two users of ScrollNode's owning_layer_id. BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2824683002 Cr-Commit-Position: refs/heads/master@{#465677} Committed: https://chromium.googlesource.com/chromium/src/+/dfd089f1bd1aa1d8512741f2a103d0b87684f2e4

Patch Set 1 #

Patch Set 2 : Rebase from space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M cc/trees/layer_tree_host_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 6 chunks +23 lines, -32 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
wkorman
lgtm
3 years, 8 months ago (2017-04-17 17:32:52 UTC) #2
weiliangc
lgtm
3 years, 8 months ago (2017-04-18 15:24:43 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2816063003 Patch 60001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-18 17:31:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824683002/20001
3 years, 8 months ago (2017-04-19 17:35:59 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:29:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dfd089f1bd1aa1d8512741f2a103...

Powered by Google App Engine
This is Rietveld 408576698