Add ClipboardTest.java back

Add ClipboardTest.java back

ClipboardText.java got deleted due to crrev/2812773002.
Some refactor because of new listener functions.

BUG=709549
Review-Url: https://codereview.chromium.org/2824593002
Cr-Commit-Position: refs/heads/master@{#465265}
Committed: https://chromium.googlesource.com/chromium/src/+/7076919baf44c4b45db4ea699b833c1485702506

[Shimi Zhang, 2017-04-14 21:34:54]

ctzsm@chromium.org changed reviewers:
+ mpearson@chromium.org, twellington@chromium.org

[Shimi Zhang, 2017-04-14 21:34:55]

twellington@, mpearson@,

ClipboardTest.java mistakenly got removed yesterday, this cl is adding it back
with some refactor.

Because some new listener functions will cause an UnstaisfiedLinkError
(org.chromium.ui.base.Clipboard.nativeInit()J), I decided to minimize the test
scope by removing the usage of setPrimaryClipNoException().

[Shimi Zhang, 2017-04-14 21:35:00]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 21:35:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark P, 2017-04-14 21:37:53]

Description was changed from

==========
Add ClipboardTest.java back

ClipboardText.java got deleted due to crrev/2812773002.
Some refactor because of new listener functions.

BUG=709549
==========

to

==========
Add ClipboardTest.java back

ClipboardText.java got deleted due to crrev/2812773002.
Some refactor because of new listener functions.

BUG=709549
==========

[Mark P, 2017-04-14 21:37:53]

mpearson@chromium.org changed reviewers:
- mpearson@chromium.org

[commit-bot: I haz the power, 2017-04-14 22:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 22:41:33]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-04-17 14:47:21]

https://codereview.chromium.org/2824593002/diff/20001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/base/Clipboard.java (right):

https://codereview.chromium.org/2824593002/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/base/Clipboard.java:101:
@SuppressWarnings("deprecation")
Typically we add methods to ApiCompatibilityUtils to handle deprecated methods.

e.g.

static public String toHtml(Spanned text, int option) {
    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
        return Html.toHtml(spanned, option);
    } else {
        return Html.toHtml(spanned);
    }
}

[Shimi Zhang, 2017-04-17 18:24:09]

https://codereview.chromium.org/2824593002/diff/20001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/base/Clipboard.java (right):

https://codereview.chromium.org/2824593002/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/base/Clipboard.java:101:
@SuppressWarnings("deprecation")
Thank you! It has been resolved. Should we add file owner for
ApiCompatibilityUtils.java to take a look?

On 2017/04/17 14:47:21, Theresa wrote:
> Typically we add methods to ApiCompatibilityUtils to handle deprecated
methods.
> 
> e.g.
> 
> static public String toHtml(Spanned text, int option) {
>     if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
>         return Html.toHtml(spanned, option);
>     } else {
>         return Html.toHtml(spanned);
>     }
> }

Done.

[Shimi Zhang, 2017-04-17 18:39:24]

ctzsm@chromium.org changed reviewers:
+ nyquist@chromium.org

[Shimi Zhang, 2017-04-17 18:39:25]

nyquist@, please take a look of ApiCompatibilityUtils.java change.

[Shimi Zhang, 2017-04-17 18:45:53]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:46:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2017-04-17 19:00:18]

https://codereview.chromium.org/2824593002/diff/40001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right):

https://codereview.chromium.org/2824593002/diff/40001/base/android/java/src/o...
base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:291: public
static String toHtml(Spanned spanned, int option) {
Could you mention in the JavaDoc that the option is ignored on < N?

[Shimi Zhang, 2017-04-17 19:47:34]

nyquist@, thanks, updated.

https://codereview.chromium.org/2824593002/diff/40001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right):

https://codereview.chromium.org/2824593002/diff/40001/base/android/java/src/o...
base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:291: public
static String toHtml(Spanned spanned, int option) {
On 2017/04/17 19:00:18, nyquist wrote:
> Could you mention in the JavaDoc that the option is ignored on < N?

Done.

[nyquist, 2017-04-17 20:26:40]

base lgtm

[Shimi Zhang, 2017-04-17 20:30:27]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 20:30:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:34:05]

Dry run: This issue passed the CQ dry run.

[Shimi Zhang, 2017-04-18 16:13:41]

Theresa, could you PTAL again, thanks!

[Theresa, 2017-04-18 16:15:48]

lgtm

[Shimi Zhang, 2017-04-18 16:36:27]

The CQ bit was checked by ctzsm@chromium.org

[commit-bot: I haz the power, 2017-04-18 16:36:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 16:40:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492533387954440,
"parent_rev": "00b225ddd0a5b1953d45ad4fdd22b7ce7baba58d", "commit_rev":
"7076919baf44c4b45db4ea699b833c1485702506"}

[commit-bot: I haz the power, 2017-04-18 16:41:05]

Description was changed from

==========
Add ClipboardTest.java back

ClipboardText.java got deleted due to crrev/2812773002.
Some refactor because of new listener functions.

BUG=709549
==========

to

==========
Add ClipboardTest.java back

ClipboardText.java got deleted due to crrev/2812773002.
Some refactor because of new listener functions.

BUG=709549

Review-Url: https://codereview.chromium.org/2824593002
Cr-Commit-Position: refs/heads/master@{#465265}
Committed:
https://chromium.googlesource.com/chromium/src/+/7076919baf44c4b45db4ea699b83...
==========

[commit-bot: I haz the power, 2017-04-18 16:41:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7076919baf44c4b45db4ea699b83...