Remove URLRequestJob::GetResponseCode implementations from AppCache.

Remove URLRequestJob::GetResponseCode implementations from AppCache.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481
Review-Url: https://codereview.chromium.org/2824583003
Cr-Commit-Position: refs/heads/master@{#465011}
Committed: https://chromium.googlesource.com/chromium/src/+/859329ee3ecac2404c5d9358e4eda08d7d27fc03

[mmenke, 2017-04-14 21:24:01]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 21:24:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 21:48:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 21:48:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-04-17 17:44:17]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 17:44:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 17:56:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 17:56:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mmenke, 2017-04-17 17:59:47]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:00:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-04-17 18:04:38]

Patchset #2 (id:20001) has been deleted

[mmenke, 2017-04-17 18:47:55]

mmenke@chromium.org changed reviewers:
+ michaeln@chromium.org

[mmenke, 2017-04-17 18:47:56]

[michaeln]:  PTAL

[commit-bot: I haz the power, 2017-04-17 18:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:55:20]

Dry run: This issue passed the CQ dry run.

[michaeln, 2017-04-17 20:32:44]

lgtm

[mmenke, 2017-04-17 20:35:37]

On 2017/04/17 20:32:44, michaeln wrote:
> lgtm

Thanks!

[mmenke, 2017-04-17 20:35:40]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-04-17 20:35:48]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:36:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:41:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492461348096900,
"parent_rev": "b1a4504cbe6e2d7dc772b1a135de04571cd8ab36", "commit_rev":
"859329ee3ecac2404c5d9358e4eda08d7d27fc03"}

[commit-bot: I haz the power, 2017-04-17 20:41:45]

Description was changed from

==========
Remove URLRequestJob::GetResponseCode implementations from AppCache.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481
==========

to

==========
Remove URLRequestJob::GetResponseCode implementations from AppCache.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481

Review-Url: https://codereview.chromium.org/2824583003
Cr-Commit-Position: refs/heads/master@{#465011}
Committed:
https://chromium.googlesource.com/chromium/src/+/859329ee3ecac2404c5d9358e4ed...
==========

[commit-bot: I haz the power, 2017-04-17 20:41:46]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/859329ee3ecac2404c5d9358e4ed...