Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2824583002: Implement <script nomodule> (Closed)

Created:
3 years, 8 months ago by Nate Chapin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, fs, blink-reviews-w3ctests_chromium.org, blink-reviews-html_chromium.org, sof, eae+blinkwatch, Yoav Weiss, fmalita+watch_chromium.org, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, krit, blink-reviews, gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement <script nomodule> BUG=681050 TEST=external/wpt/html/semantics/scripting-1/the-script-element/nomodule-* Review-Url: https://codereview.chromium.org/2824583002 Cr-Commit-Position: refs/heads/master@{#465811} Committed: https://chromium.googlesource.com/chromium/src/+/85827883d6102e09951e13c14c8d383cd6e3833f

Patch Set 1 #

Patch Set 2 : Fix a couple of tests I missed #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : RuntimeEnabled=ModuleScripts #

Total comments: 2

Patch Set 5 : Move script_type declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -70 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/html/dom/reflection-misc-expected.txt View 1 1 chunk +1 line, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/nomodule-reflect-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/nomodule-set-on-async-classic-script-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/nomodule-set-on-inline-classic-scripts-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/nomodule-set-on-synchronously-loaded-classic-scripts-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MockScriptElementBase.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptElementBase.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.json5 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLScriptElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLScriptElement.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLScriptElement.idl View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 2 3 4 4 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGScriptElement.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Nate Chapin
3 years, 8 months ago (2017-04-14 21:59:31 UTC) #5
hiroshige
I'm touching related code path, so could you rebase onto https://codereview.chromium.org/2821803002? I expect my CL ...
3 years, 8 months ago (2017-04-15 00:45:10 UTC) #9
kouhei (in TOK)
Thanks for taking this! lgtm % hiroshige comments
3 years, 8 months ago (2017-04-15 01:52:11 UTC) #10
Nate Chapin
https://codereview.chromium.org/2824583002/diff/20001/third_party/WebKit/Source/core/dom/ScriptLoader.cpp File third_party/WebKit/Source/core/dom/ScriptLoader.cpp (right): https://codereview.chromium.org/2824583002/diff/20001/third_party/WebKit/Source/core/dom/ScriptLoader.cpp#newcode167 third_party/WebKit/Source/core/dom/ScriptLoader.cpp:167: // https://html.spec.whatwg.org/#prepare-a-script, Step 11. On 2017/04/15 00:45:09, hiroshige wrote: ...
3 years, 8 months ago (2017-04-19 20:28:27 UTC) #15
hiroshige
lgtm! Thanks! https://codereview.chromium.org/2824583002/diff/60001/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp File third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp (right): https://codereview.chromium.org/2824583002/diff/60001/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp#newcode527 third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp:527: ScriptType script_type = ScriptType::kClassic; nit: this declaration ...
3 years, 8 months ago (2017-04-19 21:15:33 UTC) #16
Nate Chapin
https://codereview.chromium.org/2824583002/diff/60001/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp File third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp (right): https://codereview.chromium.org/2824583002/diff/60001/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp#newcode527 third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp:527: ScriptType script_type = ScriptType::kClassic; On 2017/04/19 21:15:33, hiroshige wrote: ...
3 years, 8 months ago (2017-04-19 21:54:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824583002/80001
3 years, 8 months ago (2017-04-19 21:55:23 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 23:44:17 UTC) #23
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/85827883d6102e09951e13c14c8d...

Powered by Google App Engine
This is Rietveld 408576698