Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 2824503003: fix menu alignment issue (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ftang
Modified:
2 months, 1 week ago
Reviewers:
groby, ftang1, Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

fix menu alignment issue BUG=701460 Review-Url: https://codereview.chromium.org/2824503003 Cr-Commit-Position: refs/heads/master@{#465015} Committed: https://chromium.googlesource.com/chromium/src/+/d6560d2fd7a498e06d8547a0b0b86bc948a24b5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
Trybot results:  win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   linux_android_rel_ng   cast_shell_android   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe   linux_chromium_rel_ng   linux_chromium_tsan_rel_ng   win_chromium_x64_rel_ng   win_clang   win_chromium_rel_ng   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   chromeos_amd64-generic_chromium_compile_only_ng   android_n5x_swarming_rel   linux_android_rel_ng   cast_shell_android   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 18 (11 generated)
ftang1
Please review
2 months, 1 week ago (2017-04-15 00:36:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824503003/1
2 months, 1 week ago (2017-04-15 00:59:51 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
2 months, 1 week ago (2017-04-15 00:59:52 UTC) #6
groby
Looks technically OK to me, but please ask a Views owner if that change fits ...
2 months, 1 week ago (2017-04-17 19:36:06 UTC) #12
Peter Kasting
LGTM
2 months, 1 week ago (2017-04-17 20:02:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824503003/1
2 months, 1 week ago (2017-04-17 20:14:01 UTC) #15
commit-bot: I haz the power
2 months, 1 week ago (2017-04-17 21:05:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6560d2fd7a498e06d8547a0b0b8...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318