MD Settings: Elim is-list-item from cr-network-list-item

MD Settings: Elim is-list-item from cr-network-list-item

Currently we use cr-network-list-item in two ways:
1. As a summary for the ntetwork type (e.g. WiFi) in the Settings UI.
2. As an item in a list of networks in Settings and OOBE.

Use case #1 complicates the code and adds extra complexity to the main
Settings UI page. Eliminating it simplifies the code with only a small
amount of duplication. It also allows more flexibility in customizing
the main Settings page layout.

BUG=704042
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2824493003
Cr-Commit-Position: refs/heads/master@{#465302}
Committed: https://chromium.googlesource.com/chromium/src/+/e3b1b256fd85fa0c846e49240e681d4f5cee91f7

[stevenjb, 2017-04-14 19:11:24]

Description was changed from

==========
MD Settings: Elim is-list-item from cr-network-list-item

Currently we use cr-network-list-item in two ways:
1. As a summary for the ntetwork type (e.g. WiFi) in the Settings UI.
2. As an item in a list of networks in Settings and OOBE.

Use case #1 complicates the code and adds extra complexity to the main
Settings UI page. Eliminating it simplifies the code with only a small
amount of duplication. It also allows more flexibility in customizing
the main Settings page layout.

BUG=704042
==========

to

==========
MD Settings: Elim is-list-item from cr-network-list-item

Currently we use cr-network-list-item in two ways:
1. As a summary for the ntetwork type (e.g. WiFi) in the Settings UI.
2. As an item in a list of networks in Settings and OOBE.

Use case #1 complicates the code and adds extra complexity to the main
Settings UI page. Eliminating it simplifies the code with only a small
amount of duplication. It also allows more flexibility in customizing
the main Settings page layout.

BUG=704042
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-14 19:29:50]

stevenjb@chromium.org changed reviewers:
+ alemate@chromium.org, michaelpg@chromium.org

[Alexander Alekseev, 2017-04-15 00:57:28]

lgtm

[michaelpg, 2017-04-17 20:24:36]

https://codereview.chromium.org/2824493003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary_item.html
(right):

https://codereview.chromium.org/2824493003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.html:19:
flex 2;
needs a colon. or if it's working as is, remove this unused line :-)

https://codereview.chromium.org/2824493003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.html:42:
<cr-network-icon network-state="[[activeNetworkState]]">
import

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_list_item.html (right):

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_list_item.html:75: <div
id="itemName">[[ariaLabel]]</div>
remove id if it's unused now

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_list_item.js (right):

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_list_item.js:7: * in a list or
summary based on ONC state properties.
cut "or summary"?

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_list_item.js:110: var network
= this.networkState;
removed these unused variables (maybe inline |state| too)

[stevenjb, 2017-04-17 21:02:39]

ptal

https://codereview.chromium.org/2824493003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary_item.html
(right):

https://codereview.chromium.org/2824493003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.html:19:
flex 2;
On 2017/04/17 20:24:35, michaelpg wrote:
> needs a colon. or if it's working as is, remove this unused line :-)

Huh. flex: 2 works, but the default '0 1 auto' works better. Removed.

https://codereview.chromium.org/2824493003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.html:42:
<cr-network-icon network-state="[[activeNetworkState]]">
On 2017/04/17 20:24:35, michaelpg wrote:
> import

Done.

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_list_item.html (right):

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_list_item.html:75: <div
id="itemName">[[ariaLabel]]</div>
On 2017/04/17 20:24:36, michaelpg wrote:
> remove id if it's unused now

Done.

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_list_item.js (right):

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_list_item.js:7: * in a list or
summary based on ONC state properties.
On 2017/04/17 20:24:36, michaelpg wrote:
> cut "or summary"?

Done.

https://codereview.chromium.org/2824493003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_list_item.js:110: var network
= this.networkState;
On 2017/04/17 20:24:36, michaelpg wrote:
> removed these unused variables (maybe inline |state| too)

Done.

[michaelpg, 2017-04-18 05:04:25]

lgtm

[stevenjb, 2017-04-18 15:09:47]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-18 15:09:47]

The patchset sent to the CQ was uploaded after l-g-t-m from alemate@chromium.org
Link to the patchset: https://codereview.chromium.org/2824493003/#ps40001
(title: "Feedback")

[commit-bot: I haz the power, 2017-04-18 15:10:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 15:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 15:24:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-04-18 17:07:18]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-18 17:07:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
alemate@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2824493003/#ps60001
(title: "Fix function definition")

[commit-bot: I haz the power, 2017-04-18 17:07:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:49:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492535238943900,
"parent_rev": "c2068dc16ea00c1f3f9e544d2f3b30f65a256a32", "commit_rev":
"e3b1b256fd85fa0c846e49240e681d4f5cee91f7"}

[commit-bot: I haz the power, 2017-04-18 18:49:45]

Description was changed from

==========
MD Settings: Elim is-list-item from cr-network-list-item

Currently we use cr-network-list-item in two ways:
1. As a summary for the ntetwork type (e.g. WiFi) in the Settings UI.
2. As an item in a list of networks in Settings and OOBE.

Use case #1 complicates the code and adds extra complexity to the main
Settings UI page. Eliminating it simplifies the code with only a small
amount of duplication. It also allows more flexibility in customizing
the main Settings page layout.

BUG=704042
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Elim is-list-item from cr-network-list-item

Currently we use cr-network-list-item in two ways:
1. As a summary for the ntetwork type (e.g. WiFi) in the Settings UI.
2. As an item in a list of networks in Settings and OOBE.

Use case #1 complicates the code and adds extra complexity to the main
Settings UI page. Eliminating it simplifies the code with only a small
amount of duplication. It also allows more flexibility in customizing
the main Settings page layout.

BUG=704042
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2824493003
Cr-Commit-Position: refs/heads/master@{#465302}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3b1b256fd85fa0c846e49240e68...
==========

[commit-bot: I haz the power, 2017-04-18 18:49:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e3b1b256fd85fa0c846e49240e68...