Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2824413002: Fix wrong inclusion of .cc file in ui/ (Closed)

Created:
3 years, 8 months ago by emaxx
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong inclusion of .cc file in ui/ BUG=713138 Review-Url: https://codereview.chromium.org/2824413002 Cr-Commit-Position: refs/heads/master@{#465691} Committed: https://chromium.googlesource.com/chromium/src/+/5395ba5587248af158c295e543c9e8e8f2307c5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
emaxx
pkasting@: PTAL.
3 years, 8 months ago (2017-04-19 12:45:19 UTC) #6
Peter Kasting
LGTM, how did that not break the build? Crazy.
3 years, 8 months ago (2017-04-19 18:40:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824413002/1
3 years, 8 months ago (2017-04-19 19:00:56 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:07:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5395ba5587248af158c295e543c9...

Powered by Google App Engine
This is Rietveld 408576698