Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Issue 2824343003: Fix deleting user account does not delete data (Closed)

Created:
3 years, 8 months ago by Roman Sorokin (ftl)
Modified:
3 years, 8 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, ljusten (tachyonic), Marton Hunyady
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromad: Fix deleting user data Deleting user account does not delete user data. Deleting user from the list first removes GaiaIdMigrationStatus so it uses email for Cryptohome identificator. Did not affect Gaia users because Chrome still uses email as identifier and not GaiaId BUG=712716 TEST=manual Review-Url: https://codereview.chromium.org/2824343003 Cr-Commit-Position: refs/heads/master@{#465771} Committed: https://chromium.googlesource.com/chromium/src/+/08590c2373943322cbcaa8e06c445cfcc7f3acd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/user_manager/user_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Roman Sorokin (ftl)
Hey Alex, PTAL.
3 years, 8 months ago (2017-04-19 09:16:20 UTC) #4
Roman Sorokin (ftl)
3 years, 8 months ago (2017-04-19 09:22:00 UTC) #7
Alexander Alekseev
lgtm
3 years, 8 months ago (2017-04-19 22:01:27 UTC) #10
Alexander Alekseev
lgtm
3 years, 8 months ago (2017-04-19 22:01:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824343003/1
3 years, 8 months ago (2017-04-19 22:02:54 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 22:09:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08590c2373943322cbcaa8e06c44...

Powered by Google App Engine
This is Rietveld 408576698