Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2824333003: Bind ContentVerifer::VerifyFailed as OnceCallback. (Closed)

Created:
3 years, 8 months ago by lazyboy
Modified:
3 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Bind ContentVerifer::VerifyFailed as OnceCallback. The consumer ContentVerifyJob, calls this only once and ContentVerifier is ref counted, so this is a good thing to do. BUG=712945 Test=No visible changes expected. Review-Url: https://codereview.chromium.org/2824333003 Cr-Commit-Position: refs/heads/master@{#465731} Committed: https://chromium.googlesource.com/chromium/src/+/e289daa9258b8646c54ae1dfcbda3f8843ba4012

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Only ContentVerifyJob::FailureCallback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M extensions/browser/content_verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_verifier.cc View 2 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/content_verify_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
lazyboy
3 years, 8 months ago (2017-04-19 17:33:48 UTC) #8
Devlin
lgtm
3 years, 8 months ago (2017-04-19 20:19:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824333003/40001
3 years, 8 months ago (2017-04-19 20:25:40 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 20:30:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e289daa9258b8646c54ae1dfcbda...

Powered by Google App Engine
This is Rietveld 408576698