Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2824293002: [inspector] cleanup all task related data when limit reached (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] cleanup all task related data when limit reached - and reduce limit to 128 * 1024. BUG=v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2824293002 Cr-Commit-Position: refs/heads/master@{#44735} Committed: https://chromium.googlesource.com/v8/v8/+/d1ba8c8546706ea6fa819ca896b33c5df4c5d3c7

Patch Set 1 #

Patch Set 2 : tuned const based on measurements #

Total comments: 2

Patch Set 3 : fixed test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M src/inspector/v8-debugger.h View 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/inspector/v8-debugger.cc View 1 2 5 chunks +22 lines, -9 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
kozy
Dmitry, please take a look. It's preparation for for removing cancel event.
3 years, 8 months ago (2017-04-18 21:04:19 UTC) #1
dgozman
lgtm, but test changes look suspicious https://codereview.chromium.org/2824293002/diff/20001/test/inspector/debugger/collect-old-async-call-chains-expected.txt File test/inspector/debugger/collect-old-async-call-chains-expected.txt (right): https://codereview.chromium.org/2824293002/diff/20001/test/inspector/debugger/collect-old-async-call-chains-expected.txt#newcode174 test/inspector/debugger/collect-old-async-call-chains-expected.txt:174: actual async chain ...
3 years, 8 months ago (2017-04-19 20:09:53 UTC) #2
kozy
https://codereview.chromium.org/2824293002/diff/20001/test/inspector/debugger/collect-old-async-call-chains-expected.txt File test/inspector/debugger/collect-old-async-call-chains-expected.txt (right): https://codereview.chromium.org/2824293002/diff/20001/test/inspector/debugger/collect-old-async-call-chains-expected.txt#newcode174 test/inspector/debugger/collect-old-async-call-chains-expected.txt:174: actual async chain len: 0 On 2017/04/19 20:09:53, dgozman ...
3 years, 8 months ago (2017-04-19 23:46:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824293002/120001
3 years, 8 months ago (2017-04-19 23:46:19 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:120001) as https://chromium.googlesource.com/v8/v8/+/d1ba8c8546706ea6fa819ca896b33c5df4c5d3c7
3 years, 8 months ago (2017-04-20 00:14:58 UTC) #14
dgozman
Please fix :-) https://codereview.chromium.org/2824293002/diff/120001/src/inspector/v8-debugger.cc File src/inspector/v8-debugger.cc (right): https://codereview.chromium.org/2824293002/diff/120001/src/inspector/v8-debugger.cc#newcode1033 src/inspector/v8-debugger.cc:1033: if (m_asyncTaskCreationStacks.find(it.second) == m_asyncTaskStacks.end()) { You ...
3 years, 8 months ago (2017-04-20 00:42:23 UTC) #15
kozy
3 years, 8 months ago (2017-04-20 00:59:02 UTC) #16
Message was sent while issue was closed.
thanks!

https://codereview.chromium.org/2824293002/diff/120001/src/inspector/v8-debug...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2824293002/diff/120001/src/inspector/v8-debug...
src/inspector/v8-debugger.cc:1033: if (m_asyncTaskCreationStacks.find(it.second)
== m_asyncTaskStacks.end()) {
On 2017/04/20 00:42:23, dgozman wrote:
> You are comparing iterator from one map to another's end().

C++ is my best friend since it allows it :)
fixed: https://codereview.chromium.org/2828133002/

Powered by Google App Engine
This is Rietveld 408576698