Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2824223003:
Update the "Execute Javascript" AppleScript error (Closed)
|
Created:
3 years, 8 months ago by spqchan Modified:
3 years, 8 months ago Reviewers:
Robert Sesek CC:
chromium-reviews, srahim+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate the "Execute Javascript" AppleScript error
Append a link to the end of the error message.
BUG=661810
Review-Url: https://codereview.chromium.org/2824223003
Cr-Commit-Position: refs/heads/master@{#466050}
Committed: https://chromium.googlesource.com/chromium/src/+/439a48ad9710adb6dbf7c39e28d26f9e35d60be8
Patch Set 1 #Patch Set 2 : Append it to the string #Messages
Total messages: 25 (16 generated)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Update AppleScript error string BUG= ========== to ========== Update the "Execute Javascript" AppleScript error BUG=661810 ==========
Description was changed from ========== Update the "Execute Javascript" AppleScript error BUG=661810 ========== to ========== Update the "Execute Javascript" AppleScript error Added a link at the end of the message BUG=661810 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Update the "Execute Javascript" AppleScript error Added a link at the end of the message BUG=661810 ========== to ========== Update the "Execute Javascript" AppleScript error Added a link to the end of the error message. BUG=661810 ==========
spqchan@chromium.org changed reviewers: + rsesek@chromium.org
PTAL
lgtm
Although I'm not sure how this part doesn't require translation since the string doesn't change. Did Rachel just mean appending this in code (though I don't think that'd work well with RTL)?
On 2017/04/19 14:59:01, Robert Sesek wrote: > doesn't change. Did Rachel just mean appending this in code (though I don't *does*
Description was changed from ========== Update the "Execute Javascript" AppleScript error Added a link to the end of the error message. BUG=661810 ========== to ========== Update the "Execute Javascript" AppleScript error Append a link to the end of the error message. BUG=661810 ==========
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/19 14:59:21, Robert Sesek wrote: > On 2017/04/19 14:59:01, Robert Sesek wrote: > > doesn't change. Did Rachel just mean appending this in code (though I don't > > *does* That's a good point. I checked with rpop and it looks like she wants to append it. I added the URL on a separate line so there shouldn't be anymore issues with RTL. Can you PTAL?
LGTM
On 2017/04/20 15:32:22, Robert Sesek wrote: > LGTM thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492708972726170,
"parent_rev": "ad589ceb60717d4314214001cf69a9d32cd2f193", "commit_rev":
"439a48ad9710adb6dbf7c39e28d26f9e35d60be8"}
Message was sent while issue was closed.
Description was changed from ========== Update the "Execute Javascript" AppleScript error Append a link to the end of the error message. BUG=661810 ========== to ========== Update the "Execute Javascript" AppleScript error Append a link to the end of the error message. BUG=661810 Review-Url: https://codereview.chromium.org/2824223003 Cr-Commit-Position: refs/heads/master@{#466050} Committed: https://chromium.googlesource.com/chromium/src/+/439a48ad9710adb6dbf7c39e28d2... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/439a48ad9710adb6dbf7c39e28d2... |
