Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2824223002: Fire the `backgroundfetchabort` event for aborted fetches (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
harkness
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, jam, harkness+watch_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fire the `backgroundfetchabort` event for aborted fetches When the status of a completed fetch is ABORTED, which can be caused by either the user (by using the notification) or the developer (by calling abort() on the registration), fire the aforementioned event. BUG=706831 Review-Url: https://codereview.chromium.org/2824223002 Cr-Commit-Position: refs/heads/master@{#465263} Committed: https://chromium.googlesource.com/chromium/src/+/438975fc49827c2b419b0c173570c4604c74c59b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -15 lines) Patch
M content/browser/background_fetch/background_fetch_context.cc View 1 chunk +19 lines, -15 lines 0 comments Download
M content/browser/background_fetch/background_fetch_service_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Peter Beverloo
+harkness for review
3 years, 8 months ago (2017-04-18 14:28:15 UTC) #3
harkness
lgtm
3 years, 8 months ago (2017-04-18 16:03:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824223002/1
3 years, 8 months ago (2017-04-18 16:27:22 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 16:39:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/438975fc49827c2b419b0c173570...

Powered by Google App Engine
This is Rietveld 408576698