Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4080)

Unified Diff: chrome/browser/ui/webui/snippets_internals_message_handler.cc

Issue 2824173005: [Content suggestions] Reveal URL with favicon in snippets-internals (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/snippets_internals_message_handler.cc
diff --git a/chrome/browser/ui/webui/snippets_internals_message_handler.cc b/chrome/browser/ui/webui/snippets_internals_message_handler.cc
index 9b7798098caa38115c50019ad18ed5fc5be22f83..08781a31e8888f4af656f3d1be3c2c0bb218ac73 100644
--- a/chrome/browser/ui/webui/snippets_internals_message_handler.cc
+++ b/chrome/browser/ui/webui/snippets_internals_message_handler.cc
@@ -53,6 +53,8 @@ std::unique_ptr<base::DictionaryValue> PrepareSuggestion(
auto entry = base::MakeUnique<base::DictionaryValue>();
entry->SetString("idWithinCategory", suggestion.id().id_within_category());
entry->SetString("url", suggestion.url().spec());
+ entry->SetString("urlWithFavicon",
+ suggestion.url_with_favicon().GetWithEmptyPath().spec());
vitaliii 2017/04/19 09:02:10 Why do you remove path?
jkrcal 2017/04/19 10:26:48 To do the same what is done in ContentSuggestionsS
vitaliii 2017/04/19 10:47:44 Do you mean that ContentSuggestionsService ignores
jkrcal 2017/04/19 11:44:07 Okay, done.
entry->SetString("title", suggestion.title());
entry->SetString("snippetText", suggestion.snippet_text());
entry->SetString("publishDate",

Powered by Google App Engine
This is Rietveld 408576698