[Content suggestions] Reveal URL with favicon in snippets-internals

chrome/browser/ui/webui/snippets_internals_message_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/snippets_internals_message_handler.h"
 
 #include <memory>
 #include <set>
 #include <utility>
 #include <vector>
@@ skipping 35 matching lines @@
 using ntp_snippets::UserClassifier;
 
 namespace {
 
 std::unique_ptr<base::DictionaryValue> PrepareSuggestion(
     const ContentSuggestion& suggestion,
     int index) {
   auto entry = base::MakeUnique<base::DictionaryValue>();
   entry->SetString("idWithinCategory", suggestion.id().id_within_category());
   entry->SetString("url", suggestion.url().spec());
+  entry->SetString("urlWithFavicon",
+                   suggestion.url_with_favicon().GetWithEmptyPath().spec());

[vitaliii, 2017/04/19 09:02:10]

Why do you remove path?

[jkrcal, 2017/04/19 10:26:48]

To do the same what is done in ContentSuggestionsService. I think this is not
worth introducing another ForDebugging method in the service.

[vitaliii, 2017/04/19 10:47:44]

Do you mean that ContentSuggestionsService ignores path (I could not see
anything related in CS)?
If yes, then you duplicating the logic here and it will become obsolete and
confusing when ContentSuggestionsService starts doing something else. 

Have you considered ignoring path inside url_with_favicon()?

[jkrcal, 2017/04/19 11:44:07]

Okay, done.

   entry->SetString("title", suggestion.title());
   entry->SetString("snippetText", suggestion.snippet_text());
   entry->SetString("publishDate",
                    TimeFormatShortDateAndTime(suggestion.publish_date()));
   entry->SetString("fetchDate",
                    TimeFormatShortDateAndTime(suggestion.fetch_date()));
   entry->SetString("publisherName", suggestion.publisher_name());
   entry->SetString("id", "content-suggestion-" + base::IntToString(index));
   entry->SetDouble("score", suggestion.score());
 
@@ skipping 389 matching lines @@
 void SnippetsInternalsMessageHandler::OnDismissedSuggestionsLoaded(
     Category category,
     std::vector<ContentSuggestion> dismissed_suggestions) {
   if (dismissed_state_[category] == DismissedState::HIDDEN) {
     return;
   }
   dismissed_suggestions_[category] = std::move(dismissed_suggestions);
   dismissed_state_[category] = DismissedState::VISIBLE;
   SendContentSuggestions();
 }