Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2824093003: chromeos: Custom services in ServiceProviderTestHelper. (Closed)

Created:
3 years, 8 months ago by Daniel Erat
Modified:
3 years, 8 months ago
Reviewers:
teravest
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Custom services in ServiceProviderTestHelper. Make ServiceProviderTestHelper support arbitrary D-Bus services instead of just org.chromium.LibCrosService. This is needed by tests for providers that are getting moved to their own services. BUG=692246 Review-Url: https://codereview.chromium.org/2824093003 Cr-Commit-Position: refs/heads/master@{#465333} Committed: https://chromium.googlesource.com/chromium/src/+/1e3f3210c07f758054460e5ca0c1bd46f9f13a3e

Patch Set 1 #

Patch Set 2 : forward-declare dbus::ObjectPath (not that it matters) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chromeos/dbus/services/service_provider_test_helper.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M chromeos/dbus/services/service_provider_test_helper.cc View 1 3 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Daniel Erat
3 years, 8 months ago (2017-04-18 19:14:09 UTC) #2
teravest
lgtm
3 years, 8 months ago (2017-04-18 19:20:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824093003/20001
3 years, 8 months ago (2017-04-18 19:22:09 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 19:44:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e3f3210c07f758054460e5ca0c1...

Powered by Google App Engine
This is Rietveld 408576698