[tools/perf] Remove default values of benchmark_dirs and top_level_dir in chromium_config module (R…

[tools/perf] Remove default values of benchmark_dirs and top_level_dir in chromium_config module (Reland)

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
R=perezju@chromium.org, kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2824053002
Cr-Commit-Position: refs/heads/master@{#465395}
Committed: https://chromium.googlesource.com/chromium/src/+/f171cc50af563f712121e80872643cd733cc9b76

[nednguyen, 2017-04-17 23:24:52]

Description was changed from

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module (Reland)

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
TBR=perezju@chromium.org
==========

to

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module (Reland)

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
TBR=perezju@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[nednguyen, 2017-04-17 23:25:02]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 23:25:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 00:27:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 00:27:26]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[nednguyen, 2017-04-18 00:53:40]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 01:02:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-04-18 01:41:43]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 01:42:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 02:46:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 02:46:32]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-04-18 11:35:15]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 11:35:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 12:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 12:06:42]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[nednguyen, 2017-04-18 12:10:24]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 12:10:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-04-18 13:00:30]

Patchset #2 (id:20001) has been deleted

[nednguyen, 2017-04-18 13:00:37]

Patchset #2 (id:40001) has been deleted

[nednguyen, 2017-04-18 13:00:45]

Patchset #2 (id:60001) has been deleted

[nednguyen, 2017-04-18 13:00:52]

Patchset #2 (id:80001) has been deleted

[nednguyen, 2017-04-18 13:01:31]

nednguyen@google.com changed reviewers:
+ kbr@chromium.org

[nednguyen, 2017-04-18 13:01:31]

PTAL since this change has a lot in it

[nednguyen, 2017-04-18 13:01:45]

Description was changed from

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module (Reland)

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
TBR=perezju@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module (Reland)

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
R=perezju@chromium.org, kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-04-18 13:19:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 13:19:54]

Dry run: This issue passed the CQ dry run.

[perezju, 2017-04-18 13:26:12]

lgtm

[nednguyen, 2017-04-18 13:26:32]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 13:26:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 14:38:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 14:38:32]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-04-18 22:05:52]

lgtm

[nednguyen, 2017-04-18 22:06:43]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-04-18 22:06:44]

The patchset sent to the CQ was uploaded after l-g-t-m from perezju@chromium.org
Link to the patchset: https://codereview.chromium.org/2824053002/#ps120001
(title: "Fix referencess")

[commit-bot: I haz the power, 2017-04-18 22:07:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 22:22:49]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492553203965540,
"parent_rev": "595c489d8a9f798a6b55a645543dc05d210d5146", "commit_rev":
"f171cc50af563f712121e80872643cd733cc9b76"}

[commit-bot: I haz the power, 2017-04-18 22:23:01]

Description was changed from

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module (Reland)

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
R=perezju@chromium.org, kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module (Reland)

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
R=perezju@chromium.org, kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2824053002
Cr-Commit-Position: refs/heads/master@{#465395}
Committed:
https://chromium.googlesource.com/chromium/src/+/f171cc50af563f712121e8087264...
==========

[commit-bot: I haz the power, 2017-04-18 22:23:02]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/f171cc50af563f712121e8087264...