Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2824023002: DevTools: Use FocusRestorer in SoftContextMenu (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use FocusRestorer in SoftContextMenu BUG=711633 Review-Url: https://codereview.chromium.org/2824023002 Cr-Commit-Position: refs/heads/master@{#466149} Committed: https://chromium.googlesource.com/chromium/src/+/90a115e025a9f68ca5136ee8c5b827c305124414

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add a test #

Total comments: 2

Patch Set 3 : Print keys in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -56 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector-unit/soft-context-menu.js View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector-unit/soft-context-menu-expected.txt View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 1 7 chunks +34 lines, -56 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
einbinder
ptal
3 years, 8 months ago (2017-04-17 21:03:02 UTC) #2
dgozman
Let's add a test. https://codereview.chromium.org/2824023002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js File third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js (right): https://codereview.chromium.org/2824023002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js#newcode82 third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js:82: this._subMenu._discardSubMenus(); You removed this method. ...
3 years, 8 months ago (2017-04-18 18:40:20 UTC) #3
einbinder
added a test https://codereview.chromium.org/2824023002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js File third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js (right): https://codereview.chromium.org/2824023002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js#newcode82 third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js:82: this._subMenu._discardSubMenus(); On 2017/04/18 at 18:40:20, dgozman ...
3 years, 8 months ago (2017-04-18 23:47:03 UTC) #4
dgozman
lgtm https://codereview.chromium.org/2824023002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector-unit/soft-context-menu-expected.txt File third_party/WebKit/LayoutTests/http/tests/inspector-unit/soft-context-menu-expected.txt (right): https://codereview.chromium.org/2824023002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector-unit/soft-context-menu-expected.txt#newcode2 third_party/WebKit/LayoutTests/http/tests/inspector-unit/soft-context-menu-expected.txt:2: [null] I'd dump the keypresses here as well ...
3 years, 8 months ago (2017-04-19 20:02:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824023002/40001
3 years, 8 months ago (2017-04-20 19:50:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/90a115e025a9f68ca5136ee8c5b827c305124414
3 years, 8 months ago (2017-04-20 21:44:52 UTC) #11
einbinder
3 years, 8 months ago (2017-04-20 21:51:12 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/2824023002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector-unit/soft-context-menu-expected.txt
(right):

https://codereview.chromium.org/2824023002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector-unit/soft-context-menu-expected.txt:2:
[null]
On 2017/04/19 at 20:02:16, dgozman wrote:
> I'd dump the keypresses here as well for readability.

Done.

Powered by Google App Engine
This is Rietveld 408576698