Initialize SkImage memory in gpu_image_decode_cache_unittest

Initialize SkImage memory in gpu_image_decode_cache_unittest

Skia legacy mips only load-do math-store, so they don't care if the
SkImage is uninitialized.

Skia srgb-correct mips may use a table lookup, so MSAN compains that
the memory is uninitialized.

The original MSAN bug was fixed by using the legacy mips (since that
was what we wanted anyway), but let's initialize the SkImage in the
test anyway.  This makes logical sense and will avoid a future bug
in the case that we actually want the srgb-correct mips.

BUG=712298
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2824013002
Cr-Commit-Position: refs/heads/master@{#465025}
Committed: https://chromium.googlesource.com/chromium/src/+/ba774d82258e8090c70077ee34fd32cf888c33e8

[msarett, 2017-04-17 20:59:30]

Description was changed from

==========
Initialize SkImage memory in gpu_image_decode_cache_unittest

Skia legacy mips only load-do math-store, so they don't care if the
SkImage is uninitialized.

Skia srgb-correct mips may use a table lookup, so MSAN compains that
the memory is uninitialized.

The original MSAN bug was fixed by using the legacy mips (since that
was what we wanted anyway), but let's initialize the SkImage in the
test anyway.  This makes logical sense and will avoid a future bug
in the case that we actually want the srgb-correct mips.

BUG=712298
==========

to

==========
Initialize SkImage memory in gpu_image_decode_cache_unittest

Skia legacy mips only load-do math-store, so they don't care if the
SkImage is uninitialized.

Skia srgb-correct mips may use a table lookup, so MSAN compains that
the memory is uninitialized.

The original MSAN bug was fixed by using the legacy mips (since that
was what we wanted anyway), but let's initialize the SkImage in the
test anyway.  This makes logical sense and will avoid a future bug
in the case that we actually want the srgb-correct mips.

BUG=712298
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[msarett1, 2017-04-17 21:00:57]

msarett@chromium.org changed reviewers:
+ ccameron@chromium.org, msarett@chromium.org, thakis@chromium.org

[ccameron, 2017-04-17 21:09:07]

lgtm, thanks for digging in on this

[msarett1, 2017-04-17 21:09:25]

The CQ bit was checked by msarett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:09:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-04-17 21:14:07]

lgtm

[commit-bot: I haz the power, 2017-04-17 21:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:21:18]

Dry run: This issue passed the CQ dry run.

[msarett1, 2017-04-17 21:22:11]

The CQ bit was checked by msarett@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:22:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:28:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492464131612340, "parent_rev":
"dc08a2b61ba62af5187cb9edb01b0ce57cf9d57f", "commit_rev":
"ba774d82258e8090c70077ee34fd32cf888c33e8"}

[commit-bot: I haz the power, 2017-04-17 21:28:13]

Description was changed from

==========
Initialize SkImage memory in gpu_image_decode_cache_unittest

Skia legacy mips only load-do math-store, so they don't care if the
SkImage is uninitialized.

Skia srgb-correct mips may use a table lookup, so MSAN compains that
the memory is uninitialized.

The original MSAN bug was fixed by using the legacy mips (since that
was what we wanted anyway), but let's initialize the SkImage in the
test anyway.  This makes logical sense and will avoid a future bug
in the case that we actually want the srgb-correct mips.

BUG=712298
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Initialize SkImage memory in gpu_image_decode_cache_unittest

Skia legacy mips only load-do math-store, so they don't care if the
SkImage is uninitialized.

Skia srgb-correct mips may use a table lookup, so MSAN compains that
the memory is uninitialized.

The original MSAN bug was fixed by using the legacy mips (since that
was what we wanted anyway), but let's initialize the SkImage in the
test anyway.  This makes logical sense and will avoid a future bug
in the case that we actually want the srgb-correct mips.

BUG=712298
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2824013002
Cr-Commit-Position: refs/heads/master@{#465025}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba774d82258e8090c70077ee34fd...
==========

[commit-bot: I haz the power, 2017-04-17 21:28:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba774d82258e8090c70077ee34fd...