GpuImageDecodeCache: Use legacy scaling

GpuImageDecodeCache: Use legacy scaling

We don't want to use sRGB correct mips in legacy mode.

This is also a speculative fix for MSAN issues.

BUG=709341
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2823973002
Cr-Commit-Position: refs/heads/master@{#464969}
Committed: https://chromium.googlesource.com/chromium/src/+/1b89b8d1e13e00b2ec19fcbce8056fd204cb1a0b

[msarett, 2017-04-17 18:09:38]

Description was changed from

==========
GpuImageDecodeCache: Use legacy scaling

We don't want to use sRGB correct mips in legacy mode.

This is also a speculative fix for MSAN issues.

BUG=709341
==========

to

==========
GpuImageDecodeCache: Use legacy scaling

We don't want to use sRGB correct mips in legacy mode.

This is also a speculative fix for MSAN issues.

BUG=709341
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[msarett1, 2017-04-17 18:09:57]

The CQ bit was checked by msarett@chromium.org to run a CQ dry run

[msarett1, 2017-04-17 18:10:09]

msarett@chromium.org changed reviewers:
+ ccameron@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:10:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-04-17 18:40:04]

lgtm

https://codereview.chromium.org/2823973002/diff/1/cc/tiles/gpu_image_decode_c...
File cc/tiles/gpu_image_decode_cache.cc (right):

https://codereview.chromium.org/2823973002/diff/1/cc/tiles/gpu_image_decode_c...
cc/tiles/gpu_image_decode_cache.cc:1104: backing_memory->data(),
image_info.minRowBytes());
Ooh, good point.

[commit-bot: I haz the power, 2017-04-17 19:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:09:56]

Dry run: This issue passed the CQ dry run.

[msarett1, 2017-04-17 19:11:22]

The CQ bit was checked by msarett@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:11:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:17:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492456282682310, "parent_rev":
"23bf5051cc684eacd9a3519470b28017b036335c", "commit_rev":
"1b89b8d1e13e00b2ec19fcbce8056fd204cb1a0b"}

[commit-bot: I haz the power, 2017-04-17 19:18:40]

Description was changed from

==========
GpuImageDecodeCache: Use legacy scaling

We don't want to use sRGB correct mips in legacy mode.

This is also a speculative fix for MSAN issues.

BUG=709341
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
GpuImageDecodeCache: Use legacy scaling

We don't want to use sRGB correct mips in legacy mode.

This is also a speculative fix for MSAN issues.

BUG=709341
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2823973002
Cr-Commit-Position: refs/heads/master@{#464969}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b89b8d1e13e00b2ec19fcbce805...
==========

[commit-bot: I haz the power, 2017-04-17 19:18:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b89b8d1e13e00b2ec19fcbce805...

[Nico, 2017-04-17 19:27:47]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-04-17 19:27:48]

Did you mean to reenable the tests in this CL?

[msarett1, 2017-04-17 19:36:56]

On 2017/04/17 19:27:48, Nico wrote:
> Did you mean to reenable the tests in this CL?

This change is a bug fix regardless of whether it fixes MSAN.  I've kicked off
another MSAN try-job on Chris' CL to see if the MSAN issue is in fact fixed.
https://codereview.chromium.org/2816173002/

Looks like it is :).