Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2823933002: Roll src\tools\gyp e7079f0e0..eb296f67d (12 commits) (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src\tools\gyp e7079f0e0..eb296f67d (12 commits) https://chromium.googlesource.com/external/gyp.git/+log/e7079f0e0e14..eb296f67da07 $ git log e7079f0e0..eb296f67d --date=short --no-merges --format='%ad %ae %s' 2017-04-15 refack [win] Add support for MS VS2017 (via Registry) 2017-03-12 refack [win-test] loosen win-driver-target-type test 2017-02-16 tandrii CQ config: add gerrit CQAbility verifier. 2017-01-20 agable Make Gerrit the default code review system for gyp 2017-01-20 agable Set up a CQ for gyp 2016-11-17 dpranke Update shared library extension on AIX to .a. 2016-11-05 dpranke msvs: Allow target platform version without WinRT 2016-10-13 addaleax Hash intermediate file name to avoid ENAMETOOLONG 2016-10-13 thechargingvolcano fix common "NameError"s 2016-08-10 jmaquieira Add new target type called windows_driver. * Modify GYP to set the PlatformToolset, the DriverType and the TargetVersion * Add msvs_target_version configuration 2016-08-05 ted.mielczarek Make the ninja backend transitively check for C++ sources to use the C++ compiler for linking 2016-08-04 marksc2222 Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py. Created with: roll-dep src\tools\gyp R=dpranke@chromium.org BUG=700524 Review-Url: https://codereview.chromium.org/2823933002 Cr-Commit-Position: refs/heads/master@{#464991} Committed: https://chromium.googlesource.com/chromium/src/+/ef0edc393def2cc4b97b2ca043b2182ba7f95ab5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
brucedawson
PTAL
3 years, 8 months ago (2017-04-17 19:01:17 UTC) #5
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-17 19:46:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823933002/1
3 years, 8 months ago (2017-04-17 19:48:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ef0edc393def2cc4b97b2ca043b2182ba7f95ab5
3 years, 8 months ago (2017-04-17 19:52:41 UTC) #11
scottmg
(Is there a bug for removing gyp from DEPS entirely? :)
3 years, 8 months ago (2017-04-18 17:31:03 UTC) #12
Dirk Pranke
3 years, 8 months ago (2017-04-18 18:15:28 UTC) #13
Message was sent while issue was closed.
On 2017/04/18 17:31:03, scottmg wrote:
> (Is there a bug for removing gyp from DEPS entirely? :)

Hm. I thought there was but I'm not seeing it at the moment. If I can't find it,
I'll file one.

Powered by Google App Engine
This is Rietveld 408576698