Delete TapButtonWithLabelId from first_run_egtest.mm.

Delete TapButtonWithLabelId from first_run_egtest.mm.

EarlGrey tests should perform taps in EarlGrey style, rather than
creating static C-methods to combine actions. Custom matchers
are used to make the code more readable.

BUG=684099
Review-Url: https://codereview.chromium.org/2823913002
Cr-Commit-Position: refs/heads/master@{#465311}
Committed: https://chromium.googlesource.com/chromium/src/+/dfc326b3c2dc9801898bba2d0f1cd2de52f83c9d

[baxley, 2017-04-17 17:28:06]

baxley@chromium.org changed reviewers:
+ liaoyuke@chromium.org

[baxley, 2017-04-17 17:28:06]

First could you let me know what you think about the overall approach of getting
rid of methods like TapButtonWithAccessibilityLabelID(...)?

[liaoyuke, 2017-04-17 21:03:28]

On 2017/04/17 17:28:06, baxley wrote:
> First could you let me know what you think about the overall approach of
getting
> rid of methods like TapButtonWithAccessibilityLabelID(...)?

lgtm! Thanks! This makes our tests much more cleaner.

[baxley, 2017-04-17 21:25:12]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[baxley, 2017-04-17 21:25:12]

+eugenebut

[Eugene But (OOO till 7-30), 2017-04-18 01:17:34]

lgtm

https://codereview.chromium.org/2823913002/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/first_run/first_run_egtest.mm (right):

https://codereview.chromium.org/2823913002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/first_run_egtest.mm:56: id<GREYMatcher>
SkipSigninButton() {
nit: s/SkipSigninButton/SkipSignInButton

[baxley, 2017-04-18 18:44:24]

Thanks for the reviews!

https://codereview.chromium.org/2823913002/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/first_run/first_run_egtest.mm (right):

https://codereview.chromium.org/2823913002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/first_run_egtest.mm:56: id<GREYMatcher>
SkipSigninButton() {
On 2017/04/18 01:17:33, Eugene But wrote:
> nit: s/SkipSigninButton/SkipSignInButton

In most of our code, we refer to "signin" as a one word noun. It isn't that
consistent, but I'll leave it as is after offline discussion.

[baxley, 2017-04-18 18:44:40]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-04-18 18:44:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
liaoyuke@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2823913002/#ps40001
(title: "don't use fixup")

[commit-bot: I haz the power, 2017-04-18 18:45:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:57:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492541080953630,
"parent_rev": "08e2c2a4a4630b46712e0cd1900e15980c8fe203", "commit_rev":
"dfc326b3c2dc9801898bba2d0f1cd2de52f83c9d"}

[commit-bot: I haz the power, 2017-04-18 18:57:34]

Description was changed from

==========
Delete TapButtonWithLabelId from first_run_egtest.mm.

EarlGrey tests should perform taps in EarlGrey style, rather than
creating static C-methods to combine actions. Custom matchers
are used to make the code more readable.

BUG=684099
==========

to

==========
Delete TapButtonWithLabelId from first_run_egtest.mm.

EarlGrey tests should perform taps in EarlGrey style, rather than
creating static C-methods to combine actions. Custom matchers
are used to make the code more readable.

BUG=684099

Review-Url: https://codereview.chromium.org/2823913002
Cr-Commit-Position: refs/heads/master@{#465311}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfc326b3c2dc9801898bba2d0f1c...
==========

[commit-bot: I haz the power, 2017-04-18 18:57:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dfc326b3c2dc9801898bba2d0f1c...