Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2823903004: [Devtools] Added product classification colorize rows to network panel (Closed)

Created:
3 years, 8 months ago by allada
Modified:
3 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Added product classification colorize rows to network panel Adds colorizing of network resource to network panel under experiments. See: http://imgur.com/a/IoMrC R=pfeldman,dgozman BUG=712876 Review-Url: https://codereview.chromium.org/2823903004 Cr-Commit-Position: refs/heads/master@{#466112} Committed: https://chromium.googlesource.com/chromium/src/+/ded9a228e452e84df5aa818e0c8f67c72ff971dc

Patch Set 1 : [Devtools] Added product classification colorize rows to network panel #

Total comments: 3

Patch Set 2 : changes #

Patch Set 3 : Merge branch 'NETWORK_COLORS' into COLORIZE_PRODUCT_TYPE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js View 1 1 chunk +9 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
allada
PTL https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js (right): https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js#newcode65 third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:65: InitiatorPath: [58, 217, 58, 0.4], I needed to ...
3 years, 8 months ago (2017-04-18 23:18:34 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js (right): https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js#newcode103 third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:103: * @param {?Array<number>} rgba You could pass color ...
3 years, 8 months ago (2017-04-18 23:50:32 UTC) #3
allada
https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js (right): https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js#newcode103 third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:103: * @param {?Array<number>} rgba On 2017/04/18 23:50:32, pfeldman wrote: ...
3 years, 8 months ago (2017-04-19 23:42:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823903004/60001
3 years, 8 months ago (2017-04-20 17:53:09 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:29:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ded9a228e452e84df5aa818e0c8f...

Powered by Google App Engine
This is Rietveld 408576698