[Devtools] Added product classification colorize rows to network panel

[Devtools] Added product classification colorize rows to network panel

Adds colorizing of network resource to network panel under experiments.

See: http://imgur.com/a/IoMrC

R=pfeldman,dgozman
BUG=712876
Review-Url: https://codereview.chromium.org/2823903004
Cr-Commit-Position: refs/heads/master@{#466112}
Committed: https://chromium.googlesource.com/chromium/src/+/ded9a228e452e84df5aa818e0c8f67c72ff971dc

[allada, 2017-04-18 23:18:15]

Patchset #1 (id:1) has been deleted

[allada, 2017-04-18 23:18:34]

PTL

https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:65:
InitiatorPath: [58, 217, 58, 0.4],
I needed to make this more prominent, so I increased it.

[pfeldman, 2017-04-18 23:50:32]

lgtm

https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:103:
* @param {?Array<number>} rgba
You could pass color instance here.

[allada, 2017-04-19 23:42:48]

https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2823903004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:103:
* @param {?Array<number>} rgba
On 2017/04/18 23:50:32, pfeldman wrote:
> You could pass color instance here.

Done.

[allada, 2017-04-20 17:52:19]

The CQ bit was checked by allada@chromium.org

[allada, 2017-04-20 17:52:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2823903004/#ps60001
(title: "Merge branch 'NETWORK_COLORS' into COLORIZE_PRODUCT_TYPE")

[commit-bot: I haz the power, 2017-04-20 17:53:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:29:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492710739985490,
"parent_rev": "d70a674eb2313aef57d03a28065a9d958ca86186", "commit_rev":
"ded9a228e452e84df5aa818e0c8f67c72ff971dc"}

[commit-bot: I haz the power, 2017-04-20 20:29:44]

Description was changed from

==========
[Devtools] Added product classification colorize rows to network panel

Adds colorizing of network resource to network panel under experiments.

See: http://imgur.com/a/IoMrC

R=pfeldman,dgozman
BUG=712876
==========

to

==========
[Devtools] Added product classification colorize rows to network panel

Adds colorizing of network resource to network panel under experiments.

See: http://imgur.com/a/IoMrC

R=pfeldman,dgozman
BUG=712876

Review-Url: https://codereview.chromium.org/2823903004
Cr-Commit-Position: refs/heads/master@{#466112}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded9a228e452e84df5aa818e0c8f...
==========

[commit-bot: I haz the power, 2017-04-20 20:29:46]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ded9a228e452e84df5aa818e0c8f...