Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2823883005: Revert of Improve canonicalization of mailto url path components (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
brettw, elawrence
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve canonicalization of mailto url path components (patchset #2 id:20001 of https://codereview.chromium.org/2817213002/ ) Reason for revert: appears to be breaking fast/url/mailto.html on at least the Mac bots: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/32726 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12/builds/1614 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/45169 diffs: -PASS canonicalize('mailto:addr1, addr2') is 'mailto:addr1, addr2' +FAIL canonicalize('mailto:addr1, addr2') should be mailto:addr1, addr2. Was mailto:addr1,%20addr2. Original issue's description: > Improve canonicalization of mailto url path components > > The canonicalization of the path component of mailto urls is too lax, leading to > information disclosure and possible command injection attacks against mail > clients. To fix this, we will percent-encode more characters in the path > component of mailto urls, matching other browsers. > > BUG=711020 > TEST=url_unittests > > Review-Url: https://codereview.chromium.org/2817213002 > Cr-Commit-Position: refs/heads/master@{#465046} > Committed: https://chromium.googlesource.com/chromium/src/+/484ff36cdcb8dcf5efa999a471d1d509c0a8a5f2 TBR=brettw@chromium.org,elawrence@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711020 Review-Url: https://codereview.chromium.org/2823883005 Cr-Commit-Position: refs/heads/master@{#465063} Committed: https://chromium.googlesource.com/chromium/src/+/468109cc91a8c236f4e74bd9e2dd094db5464d57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -64 lines) Patch
M url/url_canon_mailtourl.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M url/url_canon_unittest.cc View 2 chunks +14 lines, -45 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
alexmos
Created Revert of Improve canonicalization of mailto url path components
3 years, 8 months ago (2017-04-17 23:42:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823883005/1
3 years, 8 months ago (2017-04-17 23:42:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/468109cc91a8c236f4e74bd9e2dd094db5464d57
3 years, 8 months ago (2017-04-17 23:48:02 UTC) #6
estark
3 years, 8 months ago (2017-04-18 14:46:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2820333004/ by estark@chromium.org.

The reason for reverting is: test test.

Powered by Google App Engine
This is Rietveld 408576698