Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2823853006: Adds bounds to parameters of StubWindow constrctor (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds bounds to parameters of StubWindow constrctor This way the initial bounds can be configured during construction as with other windows. BUG=708287 TEST=covered by tests R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2823853006 Cr-Commit-Position: refs/heads/master@{#465608} Committed: https://chromium.googlesource.com/chromium/src/+/72c2b3d42fe06a1fb02fda417ae73f37dca79e1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/platform_window/stub/stub_window.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/platform_window/stub/stub_window.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 8 months ago (2017-04-19 03:24:48 UTC) #1
sadrul
lgtm
3 years, 8 months ago (2017-04-19 05:50:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823853006/1
3 years, 8 months ago (2017-04-19 15:02:24 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:08:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72c2b3d42fe06a1fb02fda417ae7...

Powered by Google App Engine
This is Rietveld 408576698