Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java

Issue 2823853004: DO NO SUMMIT: bluetooth: Use a LevelListDrawable instead of an array of drawables
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
index 5318960d85db9ea3ce46fba5c58895868eea2bd8..1629d2b2de5c632e5baa38dbf2c723dd73adf9ca 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
@@ -354,7 +354,14 @@ public class ItemChooserDialog {
ItemChooserRow item = getItem(position);
if (item.mIcon != null) {
row.mImageView.setContentDescription(item.mIconDescription);
+
+ // Save the icon's level since setImageLevel could
+ // replace the drawable's level.
+ int drawableLevel = item.mIcon.getLevel();
ortuno 2017/04/18 06:57:07 This seems pretty leaky.
David Trainor- moved to gerrit 2017/04/19 21:32:07 Should mIconLevel or "mSignalLevel" or something b
ortuno 2017/04/19 23:48:02 Oh right, we can save it as part of ItemChooserRow
+
row.mImageView.setImageDrawable(item.mIcon);
+
+ row.mImageView.setImageLevel(drawableLevel);
row.mImageView.setVisibility(View.VISIBLE);
} else {
row.mImageView.setVisibility(View.INVISIBLE);

Powered by Google App Engine
This is Rietveld 408576698